Append user exeflags to env exeflags #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 51.59% 51.63% +0.03%
==========================================
Files 30 30
Lines 1285 1286 +1
==========================================
+ Hits 663 664 +1
Misses 622 622 ☔ View full report in Codecov by Sentry. |
MichaelHatherly
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the behavior of the
QUARTONOTEBOOKRUNNER_EXEFLAGSenv variable in conjunction with theexeflagsfrontmatter variable.Before, the env variable would only have an effect if no frontmatter variable was specified. Frontmatter exeflags would fully override env exeflags. This is impractical if the env specifies a sysimage to use system-wide but a user wants to change only the number of threads for some notebook.
Therefore, this PR appends the user-specified exeflags to the env-specified ones. This has the effect of merging them as Julia ignores earlier instances of the same flags.