-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Julia 1.11 errors #191
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelHatherly
force-pushed
the
mh/1.11-fixes
branch
from
October 9, 2024 12:43
2e3bb22
to
b2a8260
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
==========================================
+ Coverage 51.51% 51.59% +0.07%
==========================================
Files 30 30
Lines 1283 1285 +2
==========================================
+ Hits 661 663 +2
Misses 622 622 ☔ View full report in Codecov by Sentry. |
MichaelHatherly
force-pushed
the
mh/1.11-fixes
branch
from
October 15, 2024 11:12
58b48d3
to
4db2bdd
Compare
MichaelHatherly
force-pushed
the
mh/1.11-fixes
branch
from
October 15, 2024 11:13
4db2bdd
to
f78bdbc
Compare
MichaelHatherly
force-pushed
the
mh/1.11-fixes
branch
from
October 16, 2024 10:41
b4df3b4
to
7723754
Compare
MichaelHatherly
commented
Oct 16, 2024
jkrumbiegel
reviewed
Oct 16, 2024
jkrumbiegel
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190.
There's a number of other test failures due to assumptions hardcoded in specific tests that will also need to be addressed before CI will pass.