Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement expand extension interface and Cell struct #135

Merged
merged 2 commits into from
May 28, 2024

Conversation

MichaelHatherly
Copy link
Collaborator

@MichaelHatherly MichaelHatherly commented May 22, 2024

Now that the worker code is an actual package, we can provide a way for 3rd-party packages to hook into the behaviour of the worker without us having to host all the integrations within this code base. E.g.

[weakdeps]
QuartoNotebookWorker = "38328d9c-a911-4051-bc06-3f7f556ffeda"

[extensions]
MyPackageNameQuartoNotebookWorkerExt = "QuartoNotebookWorker"

This adds expand and Cell that a package can use to hook in to the notebook cell expansion feature.

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 21.62162% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 53.26%. Comparing base (63c8a52) to head (315c8bf).

Files Patch % Lines
src/QuartoNotebookWorker/src/render.jl 0.00% 16 Missing ⚠️
src/QuartoNotebookWorker/src/cell_expansion.jl 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
- Coverage   53.62%   53.26%   -0.37%     
==========================================
  Files          26       27       +1     
  Lines        1199     1209      +10     
==========================================
+ Hits          643      644       +1     
- Misses        556      565       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelHatherly MichaelHatherly force-pushed the mh/is_expandable branch 2 times, most recently from 24c305e to 474f216 Compare May 24, 2024 16:09
@MichaelHatherly MichaelHatherly changed the title Implement is_expandable extension interface Implement expand extension interface and Cell struct May 24, 2024
@MichaelHatherly MichaelHatherly force-pushed the mh/is_expandable branch 2 times, most recently from 35b026c to 6e435b8 Compare May 25, 2024 08:47
@MichaelHatherly MichaelHatherly marked this pull request as ready for review May 25, 2024 08:51
README.md Outdated Show resolved Hide resolved
@MichaelHatherly MichaelHatherly merged commit 197b6e1 into main May 28, 2024
8 of 10 checks passed
@MichaelHatherly MichaelHatherly deleted the mh/is_expandable branch May 28, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants