-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement expand
extension interface and Cell
struct
#135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
==========================================
- Coverage 53.62% 53.26% -0.37%
==========================================
Files 26 27 +1
Lines 1199 1209 +10
==========================================
+ Hits 643 644 +1
- Misses 556 565 +9 ☔ View full report in Codecov by Sentry. |
MichaelHatherly
force-pushed
the
mh/is_expandable
branch
from
May 22, 2024 15:53
b4f4a1c
to
a9b5cc0
Compare
MichaelHatherly
commented
May 23, 2024
MichaelHatherly
force-pushed
the
mh/is_expandable
branch
2 times, most recently
from
May 24, 2024 16:09
24c305e
to
474f216
Compare
MichaelHatherly
changed the title
Implement
Implement May 24, 2024
is_expandable
extension interfaceexpand
extension interface and Cell
struct
MichaelHatherly
force-pushed
the
mh/is_expandable
branch
2 times, most recently
from
May 25, 2024 08:47
35b026c
to
6e435b8
Compare
MichaelHatherly
force-pushed
the
mh/is_expandable
branch
from
May 25, 2024 08:49
6e435b8
to
b51cdb7
Compare
jkrumbiegel
reviewed
May 28, 2024
jkrumbiegel
reviewed
May 28, 2024
jkrumbiegel
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the worker code is an actual package, we can provide a way for 3rd-party packages to hook into the behaviour of the worker without us having to host all the integrations within this code base. E.g.
This adds
expand
andCell
that a package can use to hook in to the notebook cell expansion feature.