This repository has been archived by the owner on Sep 28, 2020. It is now read-only.
Make most setup script flags work #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
load_development_data destroys and recreates the database and runs migrations. Since load_development_data will only be called after update, there's no reason to run them in update.
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes changes to make most
setup.pyflags work.The (mostly) working flags are:
-gX(load geolevels, very slow)-V(create database views)-t(create template plans)-s(collect static files)-l(create language files)The broken flags are:
-G(was blocked by-gX, may not be any more, but I'm out of time to investigate right now)-a(create adjacencies, depends on a data file that I don't have a good mock for)-nX(nest geolevel X, relies on old geos interface)Remaining known issues with the flags are captured in #472.
It also removes several flags that existed to enable functionality that either is no longer intended or is no longer necessary with a more modern django.
Checklist
Testing
docker-compose build./scripts/load_development_data-- runs migrations, downloads a shapefile, loads shapes from the shapefile into the database (runssetup.py ... -g0, proving functionality). You can cancel this after a minute or two if you're feeling impatient.docker-compose exec django bash./setup.py config/config.xsd config/config.xmlwith each of the other working flags above-tand-s.-tdepends on running I think-g1and also-n1. It has data dependencies. If you let-g0run for a little bit though, two plans succeed, which you can check with:from the django shell.
-sfails because I uninstalledcompressorwhen I setup the dev environment 🤦♂️. Should be an easy fix.