Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

June 24 update #962

Merged
merged 227 commits into from
Jun 11, 2024
Merged

June 24 update #962

merged 227 commits into from
Jun 11, 2024

Conversation

lizihao-anu
Copy link
Contributor

No description provided.

Jennit07 and others added 30 commits January 16, 2024 15:39
This was causing NSUs to show a social care id. This now resolves this.
@SwiftySalmon spotted an issue where NSUs were showing a social care id
attached. This was due to us matching on NSUs first and then SC Client
variables at the end. Previously we matched SC client variables first
and then NSUs onto the episode file. This difference occurred when we
split up matching on client variables at the year specific extracts.
This is a quick PR to reorder the functions to match our previous logic.
I have tested the 1920 file to check this and the issue is no longer
there.
Improved the function `create_demog_test_flags` function to include a
parameter for specifying `chi` or `anon_chi`. This is due to this
function being used for testing the extracts (which calls chi) and also
being used for testing the episode and individual file (which calls
anon_chi). This now allows flexibility for interchanging between the two
forms and simplifies the code by removing duplicated code.

Closes #850

This comment has been minimized.

@lizihao-anu

This comment has been minimized.

This comment has been minimized.

@lizihao-anu lizihao-anu requested a review from Jennit07 June 10, 2024 13:50
arrow package requries 4.0 or newer

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

check-spelling run (push) for 966-github-action-spell-checking-issues-cannot-properly-recognize-variants

Signed-off-by: check-spelling-bot <[email protected]>
on-behalf-of: @check-spelling <[email protected]>

This comment has been minimized.

check-spelling run (pull_request_target) for June-24-update

Signed-off-by: check-spelling-bot <[email protected]>
on-behalf-of: @check-spelling <[email protected]>
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (3)

GLS
HSCDIIP
SPSS

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository
on the June-24-update branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/9465704282/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (246) from .github/actions/spelling/expect.txt and unrecognized words (3)

Dictionary Entries Covers Uniquely
cspell:npm/dict/npm.txt 302 3
cspell:k8s/dict/k8s.txt 153 2 1
cspell:swift/src/swift.txt 53 2
cspell:java/src/java-terms.txt 920 2
cspell:python/src/python/python-lib.txt 2417 2

Consider adding them (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

      with:
        extra_dictionaries:
          cspell:npm/dict/npm.txt
          cspell:k8s/dict/k8s.txt
          cspell:swift/src/swift.txt
          cspell:java/src/java-terms.txt
          cspell:python/src/python/python-lib.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

check_extra_dictionaries: ''
Errors (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ ignored-expect-variant 3

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@lizihao-anu lizihao-anu added this pull request to the merge queue Jun 11, 2024
Merged via the queue into master with commit f047aab Jun 11, 2024
13 of 14 checks passed
@lizihao-anu lizihao-anu deleted the June-24-update branch June 11, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants