-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
June 24 update #962
June 24 update #962
Conversation
This was causing NSUs to show a social care id. This now resolves this.
This reverts commit 004e831.
@SwiftySalmon spotted an issue where NSUs were showing a social care id attached. This was due to us matching on NSUs first and then SC Client variables at the end. Previously we matched SC client variables first and then NSUs onto the episode file. This difference occurred when we split up matching on client variables at the year specific extracts. This is a quick PR to reorder the functions to match our previous logic. I have tested the 1920 file to check this and the issue is no longer there.
Improved the function `create_demog_test_flags` function to include a parameter for specifying `chi` or `anon_chi`. This is due to this function being used for testing the extracts (which calls chi) and also being used for testing the episode and individual file (which calls anon_chi). This now allows flexibility for interchanging between the two forms and simplifies the code by removing duplicated code. Closes #850
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Update for https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/9419296266/attempts/1 Accepted in #962 (comment) Signed-off-by: check-spelling-bot <[email protected]> on-behalf-of: @check-spelling <[email protected]>
This comment has been minimized.
This comment has been minimized.
arrow package requries 4.0 or newer
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This reverts commit 1df8bc4.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This reverts commit a35dc65.
This comment has been minimized.
This comment has been minimized.
check-spelling run (push) for 966-github-action-spell-checking-issues-cannot-properly-recognize-variants Signed-off-by: check-spelling-bot <[email protected]> on-behalf-of: @check-spelling <[email protected]>
This comment has been minimized.
This comment has been minimized.
check-spelling run (pull_request_target) for June-24-update Signed-off-by: check-spelling-bot <[email protected]> on-behalf-of: @check-spelling <[email protected]>
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details. Unrecognized words (3)GLS To accept these unrecognized words as correct, you could run the following commands... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/9465704282/attempts/1' OR To have the bot accept them for you, reply quoting the following line: Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionaryThis includes both expected items (246) from .github/actions/spelling/expect.txt and unrecognized words (3)
Consider adding them (in with:
extra_dictionaries:
cspell:npm/dict/npm.txt
cspell:k8s/dict/k8s.txt
cspell:swift/src/swift.txt
cspell:java/src/java-terms.txt
cspell:python/src/python/python-lib.txt To stop checking additional dictionaries, add (in check_extra_dictionaries: '' Errors (1)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
No description provided.