Bug - match on client variables before NSU

[Jennit07]

@SwiftySalmon spotted an issue where NSUs were showing a social care id attached. This was due to us matching on NSUs first and then SC Client variables at the end. Previously we matched SC client variables first and then NSUs onto the episode file. This difference occurred when we split up matching on client variables at the year specific extracts. This is a quick PR to reorder the functions to match our previous logic. I have tested the 1920 file to check this and the issue is no longer there.

[SwiftySalmon]

Looks good! Change makes sense

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (4)

beddays
hri
sourcedev
yyyyqx

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository
on the bug-client-vars branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/7641223037/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (235) from .github/actions/spelling/expect.txt and unrecognized words (4)

Dictionary	Entries	Covers	Uniquely
cspell:k8s/dict/k8s.txt	153	2	1
cspell:lorem-ipsum/dictionary.txt	243	1	1
cspell:scala/dict/scala.txt	153	1
cspell:npm/dict/npm.txt	302	1
cspell:dotnet/dict/dotnet.txt	405	1

Consider adding them (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

      with:
        extra_dictionaries:
          cspell:k8s/dict/k8s.txt
          cspell:lorem-ipsum/dictionary.txt
          cspell:scala/dict/scala.txt
          cspell:npm/dict/npm.txt
          cspell:dotnet/dict/dotnet.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

check_extra_dictionaries: ''

Errors (2)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors	Count
❌ ignored-expect-variant	13
ℹ️ no-newline-at-eof	1

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.