-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug - keep population filter and nsu pop not working #878
Conversation
This was set as n=1 which was then applying the function to groups rather than individuals. By setting to the varible, it picks up the correct size.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details. Unrecognized words (2)popluation To accept these unrecognized words as correct, you could run the following commands... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/7164861013/attempts/1' OR To have the bot accept them for you, reply quoting the following line: Pattern suggestions ✂️ (1)You could add these patterns to
Errors (3)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thank you for fixing the code!
We had a call to discuss the filter for deaths at the mid point of calendar year. This includes the changes we discussed. There was also the issue of the function
rbinom
not working correctly and selecting out whole groups rather than random samples from each group. This now works. I will run the code tomorrow to produce some of the tables but Rachel and I checked the keep population flag counts for 1819 and it seems a lot more reasonable with the figures. Great work everyone! Thanks