-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sc_client from individual file and add to ep file #853
Remove sc_client from individual file and add to ep file #853
Conversation
…t to `process_lookup_sc_client` instead
Also, fixed get boxi extract paths. R TO DO - add in code to episode file
This comment has been minimized.
This comment has been minimized.
HI @lizihao-anu I've added some comments to your PR and also indicated where i agree with where you intend to remove parts of the code. Happy to have a discussion about any of the comments or parts of the code that you are unsure of. Overall i think we are almost there with this. Great work! Thanks |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a call to discuss changes and agree this is ready for merging. One thing to check when running the episode file is to ensure the client file has matched on correctly.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details. Unrecognized words (2)beddays To accept these unrecognized words as correct, you could run the following commands... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/6946859739/attempts/1' OR To have the bot accept them for you, reply quoting the following line: Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionaryThis includes both expected items (232) from .github/actions/spelling/expect.txt and unrecognized words (2)
Consider adding them (in with:
extra_dictionaries:
cspell:swift/src/swift.txt
cspell:fullstack/dict/fullstack.txt
cspell:csharp/csharp.txt
cspell:java/src/java-terms.txt
cspell:typescript/dict/typescript.txt To stop checking additional dictionaries, add (in check_extra_dictionaries: '' Errors (2)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
Close #741
Quite a few details need to be discussed before merge.