Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sc_client from individual file and add to ep file #853

Merged
merged 29 commits into from
Nov 21, 2023

Conversation

lizihao-anu
Copy link
Contributor

Close #741

Quite a few details need to be discussed before merge.

This comment has been minimized.

R/create_episode_file.R Outdated Show resolved Hide resolved
R/create_episode_file.R Outdated Show resolved Hide resolved
R/process_extract_sds.R Outdated Show resolved Hide resolved
R/process_extract_sds.R Outdated Show resolved Hide resolved
R/process_extract_sds.R Outdated Show resolved Hide resolved
_targets.R Show resolved Hide resolved
@Jennit07
Copy link
Collaborator

Jennit07 commented Nov 6, 2023

Close #741

Quite a few details need to be discussed before merge.

HI @lizihao-anu I've added some comments to your PR and also indicated where i agree with where you intend to remove parts of the code. Happy to have a discussion about any of the comments or parts of the code that you are unsure of. Overall i think we are almost there with this. Great work! Thanks

This comment has been minimized.

R/create_episode_file.R Outdated Show resolved Hide resolved
R/create_episode_file.R Outdated Show resolved Hide resolved

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Collaborator

@Jennit07 Jennit07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a call to discuss changes and agree this is ready for merging. One thing to check when running the episode file is to ensure the client file has matched on correctly.

@Jennit07 Jennit07 enabled auto-merge (squash) November 21, 2023 16:34
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (2)

beddays
hri

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository
on the remove-client-data-from-individual-social-care branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/6946859739/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (232) from .github/actions/spelling/expect.txt and unrecognized words (2)

Dictionary Entries Covers Uniquely
cspell:swift/src/swift.txt 53 2
cspell:fullstack/dict/fullstack.txt 419 1 1
cspell:csharp/csharp.txt 32 1
cspell:java/src/java-terms.txt 920 1
cspell:typescript/dict/typescript.txt 1098 1

Consider adding them (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

      with:
        extra_dictionaries:
          cspell:swift/src/swift.txt
          cspell:fullstack/dict/fullstack.txt
          cspell:csharp/csharp.txt
          cspell:java/src/java-terms.txt
          cspell:typescript/dict/typescript.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

check_extra_dictionaries: ''
Errors (2)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ ignored-expect-variant 13
ℹ️ no-newline-at-eof 1

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@Jennit07 Jennit07 disabled auto-merge November 21, 2023 16:38
@Jennit07 Jennit07 enabled auto-merge (squash) November 21, 2023 16:41
@Jennit07 Jennit07 merged commit a79b686 into dec-update-23 Nov 21, 2023
11 of 12 checks passed
@Jennit07 Jennit07 deleted the remove-client-data-from-individual-social-care branch November 21, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants