-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1018 moving dd hl1 #1019
1018 moving dd hl1 #1019
Conversation
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details. Unrecognized words (2)epsidoe Previously acknowledged words that are now absentanomymous datas scoial spss 🫥To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/11462527278/attempts/1' OR To have the bot accept them for you, reply quoting the following line: Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionaryThis includes both expected items (313) from .github/actions/spelling/expect.txt and unrecognized words (2)
Consider adding them (in with:
extra_dictionaries:
cspell:fullstack/dict/fullstack.txt
cspell:k8s/dict/k8s.txt
cspell:php/dict/php.txt
cspell:node/dict/node.txt
cspell:npm/dict/npm.txt To stop checking additional dictionaries, add (in check_extra_dictionaries: '' Pattern suggestions ✂️ (1)You could add these patterns to
Errors (2)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
* Move `cli` warning messages before `return()` (#1016) * reorder episode file functions cli messages * reorder indiv file functions cli messages * Refine cli messages * reorder cli messages * Style code --------- Co-authored-by: Jennit07 <[email protected]> * Update check_year_valid.R (#1017) Co-authored-by: Jennit07 <[email protected]> * Remove person_id. Matched in later process * Remove redundant #TODO comments * remove redundant #TODO comments * Update news - sep release date * Write temp data (#1014) * add_test_to_filename and write_temp_data function * Update documentation * remove test_mode default * Update documentation * add read_temp_data * Style code * Update documentation * change test_mode to write_temp_to_disk and add clean temp function * Update documentation * Style code * Style code * Include extra temp file --------- Co-authored-by: lizihao-anu <[email protected]> Co-authored-by: Jennit07 <[email protected]> Co-authored-by: Jennit07 <[email protected]> Co-authored-by: Jennifer Thom <[email protected]> * sequence writing tests to excel (#1013) * sequence writing tests to excel * Style code * minor changes * fix bugs in anonymous function --------- Co-authored-by: lizihao-anu <[email protected]> Co-authored-by: Jennit07 <[email protected]> * Sc latest quarter (#1012) * prompt warnings of latest period when reading in sc data * Style code * add warning to show latest quarter for sc client * Style code * Update R/read_lookup_sc_client.R Co-authored-by: Jennit07 <[email protected]> * Update R/read_lookup_sc_demographics.R Co-authored-by: Jennit07 <[email protected]> * Update R/read_sc_all_alarms_telecare.R Co-authored-by: Jennit07 <[email protected]> * Update R/read_sc_all_care_home.R Co-authored-by: Jennit07 <[email protected]> * Update R/read_sc_all_home_care.R Co-authored-by: Jennit07 <[email protected]> * Update R/read_sc_all_sds.R Co-authored-by: Jennit07 <[email protected]> --------- Co-authored-by: lizihao-anu <[email protected]> Co-authored-by: Jennit07 <[email protected]> * death join and distinct refined death (#1015) * distinct death date, keep the earliest one and remove na * add activity after death 100% accurate joining * Style code * remove redundant combine death function * Update documentation * fix NA in activity_after_death * Style code --------- Co-authored-by: lizihao-anu <[email protected]> Co-authored-by: Jennit07 <[email protected]> * 1018 moving dd hl1 (#1019) * moving dd and homelessness to front * fix typos * Update documentation * Style code --------- Co-authored-by: lizihao-anu <[email protected]> Co-authored-by: Jennit07 <[email protected]> * Update process_extract_ae.R (#1020) * Update process_extract_ae.R * Style code --------- Co-authored-by: lizihao-anu <[email protected]> * Organise pre processing scripts (#1023) * Create a new folder to organise scripts * Add comments * Move script to folder * Style code --------- Co-authored-by: Jennit07 <[email protected]> * Clean test folder (#1021) * Update refs script * Add check_year_valid to update_refs script * Update documentation * Add description to 00_update_refs * Update wb name and paths for write_xlsx * Style code * Clean up github redundant scripts * Rename script to match function name * Update documentation * Update cost test path * write to disk only if file does not exist * Remove object * Update R/00-update_refs.R Co-authored-by: Zihao Li <[email protected]> --------- Co-authored-by: Jennit07 <[email protected]> Co-authored-by: Zihao Li <[email protected]> * Update homelessness completeness code (#1026) * Update homelessness completeness * Style code --------- Co-authored-by: Jennit07 <[email protected]> * Update documentation * update namespace * Update references * update process_tests_sc_demographics * Update - write temp file on `create_episode_file` * get_chi for data * Style code * IT deaths changes * Style code * remove get_chi * Specify year in episode file tests * specify year in indiv tests * Update `check_year_valid` * Fix `ch_provider` new coding guidance * Add `full.names` parameter to `write_temp_data` * Revert "Fix `ch_provider` new coding guidance" This reverts commit d2d584b. * filter na episodes by filtering period * Update running scripts indiv file * Update `check_year_valid` * update end_date * Update NEWS.md * Update create_individual_file.R * update test-check_year_valid * fix binding issue and remove redundance * Style code * R cmd check over v4.1.2 --------- Co-authored-by: Jennit07 <[email protected]> Co-authored-by: Jennit07 <[email protected]> Co-authored-by: Jennifer Thom <[email protected]> Co-authored-by: lizihao-anu <[email protected]>
moving dd and homelessness to top of create_epsidoe_file. But the memory issue for fy 1819 is still unsolved.