Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build tests #63

Merged
merged 6 commits into from
Dec 12, 2023
Merged

Fix build tests #63

merged 6 commits into from
Dec 12, 2023

Conversation

Jennit07
Copy link
Contributor

Some outstanding but opening a PR to view the changes. Some issues with variables not matching the number of variables within the file. This is due to the older files not matching the newly updated files.

@Moohan Moohan changed the base branch from production to development July 26, 2023 08:43
@Moohan
Copy link
Member

Moohan commented Jul 26, 2023

This seems to work, however, the tests now run very slowly. I think they can be sped up by extracting the data as an Arrow Table i.e. read_slf_episode("1819", as_data_frame = FALSE) %>% sample() %>% dplyr::collect()). Can you experiment with this please and see if it works and is faster?

The other suggestion is that we don't always need to use slice_sample and sometimes slice_head will be fine (and more consistent since it's not random.

@Jennit07 Jennit07 changed the base branch from development to production December 12, 2023 14:09
@Jennit07 Jennit07 changed the base branch from production to development December 12, 2023 14:34
@Jennit07 Jennit07 added this pull request to the merge queue Dec 12, 2023
Merged via the queue into development with commit a69a61c Dec 12, 2023
9 checks passed
@Jennit07 Jennit07 deleted the fix_tests branch December 12, 2023 14:37
github-merge-queue bot added a commit that referenced this pull request Aug 19, 2024
* Update to dev version

* Make testthat run in parallel

* Fix build tests (#63)

* Update variables to pass tests

* Update indiv number of variables

* Change exists tests to read

* Set an environment var to make testthat use multiple CPUs

---------

Co-authored-by: James McMahon <[email protected]>

* Bug/tidyselect not working (#85)

* Allow using tidyselect helpers with `col_select`

* Add some tests for tidyselect helpers

* Update documentation

* recid and partnership filter
allow for recid and partnership filter when they are not specified to select in columns

* Style package

* update tests

---------

Co-authored-by: Moohan <[email protected]>
Co-authored-by: Zihao Li <[email protected]>
Co-authored-by: lizihao-anu <[email protected]>

* Documentation (#88)

* Update maintainer to Megan (#69)

* Update README.Rmd (#64)

Co-authored-by: Jennit07 <[email protected]>

* Bug - speed up `get_chi()` (#68)

* Update to dev version

* Make testthat run in parallel

* Update variables to pass tests

* Update indiv number of variables

* Change exists tests to read

* Set an environment var to make testthat use multiple CPUs

* Revert changes and deal with NA chi/anon_chi

* Update documentation

* Style package

* Update tests so that they pass

* Style package

* fix tests

* Render `README.md` after changes to the `.Rmd` version

* exclude from tests for now

---------

Co-authored-by: James McMahon <[email protected]>
Co-authored-by: Jennit07 <[email protected]>

* Render `README.md` after changes to the `.Rmd` version (#70)

Co-authored-by: github-merge-queue[bot] <github-merge-queue[bot]@users.noreply.github.com>
Co-authored-by: Jennit07 <[email protected]>

* Bump actions/checkout from 3 to 4 (#66)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jennit07 <[email protected]>

* Bump peter-evans/create-pull-request from 4 to 5 (#65)

Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 4 to 5.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v4...v5)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jennit07 <[email protected]>

* Bump stefanzweifel/git-auto-commit-action from 4 to 5 (#67)

Bumps [stefanzweifel/git-auto-commit-action](https://github.com/stefanzweifel/git-auto-commit-action) from 4 to 5.
- [Release notes](https://github.com/stefanzweifel/git-auto-commit-action/releases)
- [Changelog](https://github.com/stefanzweifel/git-auto-commit-action/blob/master/CHANGELOG.md)
- [Commits](stefanzweifel/git-auto-commit-action@v4...v5)

---
updated-dependencies:
- dependency-name: stefanzweifel/git-auto-commit-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jennit07 <[email protected]>

* Bump JamesIves/github-pages-deploy-action from 4.4.3 to 4.5.0 (#71)

Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.4.3 to 4.5.0.
- [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases)
- [Commits](JamesIves/github-pages-deploy-action@v4.4.3...v4.5.0)

---
updated-dependencies:
- dependency-name: JamesIves/github-pages-deploy-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/upload-artifact from 3 to 4 (#72)

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jennit07 <[email protected]>

* Bump peter-evans/create-pull-request from 5 to 6 (#74)

Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 5 to 6.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v5...v6)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/cache from 3 to 4 (#73)

Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jennit07 <[email protected]>

* Update README.md (#75)

Updated to include reading in LTC 'catch all' variables

* change in episode file cost variable vector (#76)

Co-authored-by: marjom02 <[email protected]>

* force keytime format to hms (#77)

* force keytime format to hms

* Update documentation

* visible binding for global variables like ‘keytime1’

* minor changes

* fix keytime in column names

* import hms

---------

Co-authored-by: lizihao-anu <[email protected]>

* Bump JamesIves/github-pages-deploy-action from 4.5.0 to 4.6.0 (#79)

Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases)
- [Commits](JamesIves/github-pages-deploy-action@v4.5.0...v4.6.0)

---
updated-dependencies:
- dependency-name: JamesIves/github-pages-deploy-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* add vignette for SLFhelper documentation

* Style package

* Hide messages

* remove conflict

* Style package

* Split up documentation into 3 vignettes

* add a comparison table to show the efficiency improvement

* Update - round memory size

* replace columns by col_select and add tidyselect

* Style package

* update ep_file_vars and indiv_file_vars

* add session memory recommendation

* Update R-CMD-check.yaml

* fix cmd build error

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: James McMahon <[email protected]>
Co-authored-by: Jennit07 <[email protected]>
Co-authored-by: Jennit07 <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-merge-queue[bot] <github-merge-queue[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Megan McNicol <[email protected]>
Co-authored-by: marjom02 <[email protected]>
Co-authored-by: lizihao-anu <[email protected]>
Co-authored-by: Jennifer Thom <[email protected]>

* Update documentation (#90)

Co-authored-by: github-merge-queue[bot] <118344674+github-merge-queue[bot]@users.noreply.github.com>
Co-authored-by: Jennit07 <[email protected]>

* Bump JamesIves/github-pages-deploy-action from 4.6.0 to 4.6.3 (#82)

Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.6.0 to 4.6.3.
- [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases)
- [Commits](JamesIves/github-pages-deploy-action@v4.6.0...v4.6.3)

---
updated-dependencies:
- dependency-name: JamesIves/github-pages-deploy-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jennit07 <[email protected]>

* Increment version number to 0.10.2 (#81)

* Increment version number to 0.10.2

* update description

* Update R-CMD-check.yaml

* Update yaml

---------

Co-authored-by: Zihao Li <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: James McMahon <[email protected]>
Co-authored-by: Jennit07 <[email protected]>
Co-authored-by: Moohan <[email protected]>
Co-authored-by: lizihao-anu <[email protected]>
Co-authored-by: Jennit07 <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-merge-queue[bot] <github-merge-queue[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Megan McNicol <[email protected]>
Co-authored-by: marjom02 <[email protected]>
Co-authored-by: Jennifer Thom <[email protected]>
Co-authored-by: github-merge-queue[bot] <118344674+github-merge-queue[bot]@users.noreply.github.com>
github-merge-queue bot added a commit that referenced this pull request Sep 9, 2024
* Update to dev version

* Make testthat run in parallel

* Fix build tests (#63)

* Update variables to pass tests

* Update indiv number of variables

* Change exists tests to read

* Set an environment var to make testthat use multiple CPUs

---------

Co-authored-by: James McMahon <[email protected]>

* Bug/tidyselect not working (#85)

* Allow using tidyselect helpers with `col_select`

* Add some tests for tidyselect helpers

* Update documentation

* recid and partnership filter
allow for recid and partnership filter when they are not specified to select in columns

* Style package

* update tests

---------

Co-authored-by: Moohan <[email protected]>
Co-authored-by: Zihao Li <[email protected]>
Co-authored-by: lizihao-anu <[email protected]>

* Documentation (#88)

* Update maintainer to Megan (#69)

* Update README.Rmd (#64)

Co-authored-by: Jennit07 <[email protected]>

* Bug - speed up `get_chi()` (#68)

* Update to dev version

* Make testthat run in parallel

* Update variables to pass tests

* Update indiv number of variables

* Change exists tests to read

* Set an environment var to make testthat use multiple CPUs

* Revert changes and deal with NA chi/anon_chi

* Update documentation

* Style package

* Update tests so that they pass

* Style package

* fix tests

* Render `README.md` after changes to the `.Rmd` version

* exclude from tests for now

---------

Co-authored-by: James McMahon <[email protected]>
Co-authored-by: Jennit07 <[email protected]>

* Render `README.md` after changes to the `.Rmd` version (#70)

Co-authored-by: github-merge-queue[bot] <github-merge-queue[bot]@users.noreply.github.com>
Co-authored-by: Jennit07 <[email protected]>

* Bump actions/checkout from 3 to 4 (#66)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jennit07 <[email protected]>

* Bump peter-evans/create-pull-request from 4 to 5 (#65)

Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 4 to 5.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v4...v5)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jennit07 <[email protected]>

* Bump stefanzweifel/git-auto-commit-action from 4 to 5 (#67)

Bumps [stefanzweifel/git-auto-commit-action](https://github.com/stefanzweifel/git-auto-commit-action) from 4 to 5.
- [Release notes](https://github.com/stefanzweifel/git-auto-commit-action/releases)
- [Changelog](https://github.com/stefanzweifel/git-auto-commit-action/blob/master/CHANGELOG.md)
- [Commits](stefanzweifel/git-auto-commit-action@v4...v5)

---
updated-dependencies:
- dependency-name: stefanzweifel/git-auto-commit-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jennit07 <[email protected]>

* Bump JamesIves/github-pages-deploy-action from 4.4.3 to 4.5.0 (#71)

Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.4.3 to 4.5.0.
- [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases)
- [Commits](JamesIves/github-pages-deploy-action@v4.4.3...v4.5.0)

---
updated-dependencies:
- dependency-name: JamesIves/github-pages-deploy-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/upload-artifact from 3 to 4 (#72)

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jennit07 <[email protected]>

* Bump peter-evans/create-pull-request from 5 to 6 (#74)

Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 5 to 6.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v5...v6)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/cache from 3 to 4 (#73)

Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jennit07 <[email protected]>

* Update README.md (#75)

Updated to include reading in LTC 'catch all' variables

* change in episode file cost variable vector (#76)

Co-authored-by: marjom02 <[email protected]>

* force keytime format to hms (#77)

* force keytime format to hms

* Update documentation

* visible binding for global variables like ‘keytime1’

* minor changes

* fix keytime in column names

* import hms

---------

Co-authored-by: lizihao-anu <[email protected]>

* Bump JamesIves/github-pages-deploy-action from 4.5.0 to 4.6.0 (#79)

Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases)
- [Commits](JamesIves/github-pages-deploy-action@v4.5.0...v4.6.0)

---
updated-dependencies:
- dependency-name: JamesIves/github-pages-deploy-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* add vignette for SLFhelper documentation

* Style package

* Hide messages

* remove conflict

* Style package

* Split up documentation into 3 vignettes

* add a comparison table to show the efficiency improvement

* Update - round memory size

* replace columns by col_select and add tidyselect

* Style package

* update ep_file_vars and indiv_file_vars

* add session memory recommendation

* Update R-CMD-check.yaml

* fix cmd build error

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: James McMahon <[email protected]>
Co-authored-by: Jennit07 <[email protected]>
Co-authored-by: Jennit07 <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-merge-queue[bot] <github-merge-queue[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Megan McNicol <[email protected]>
Co-authored-by: marjom02 <[email protected]>
Co-authored-by: lizihao-anu <[email protected]>
Co-authored-by: Jennifer Thom <[email protected]>

* Update documentation (#90)

Co-authored-by: github-merge-queue[bot] <118344674+github-merge-queue[bot]@users.noreply.github.com>
Co-authored-by: Jennit07 <[email protected]>

* Bump JamesIves/github-pages-deploy-action from 4.6.0 to 4.6.3 (#82)

Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.6.0 to 4.6.3.
- [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases)
- [Commits](JamesIves/github-pages-deploy-action@v4.6.0...v4.6.3)

---
updated-dependencies:
- dependency-name: JamesIves/github-pages-deploy-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jennit07 <[email protected]>

* Increment version number to 0.10.2 (#81)

* Increment version number to 0.10.2

* update description

* Update R-CMD-check.yaml

* Update yaml

---------

Co-authored-by: Zihao Li <[email protected]>

* Fix the tidyselect feature bug (#95)

* reconstruct read_slf to fix bug of selecting feature

* Update documentation

* remove TODO add a filter by recid as it has been done

* Style package

* update ep and individual file variables

---------

Co-authored-by: lizihao-anu <[email protected]>
Co-authored-by: Jennit07 <[email protected]>

* Increment version number to 0.10.4

* Update NEWS

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: James McMahon <[email protected]>
Co-authored-by: Moohan <[email protected]>
Co-authored-by: Zihao Li <[email protected]>
Co-authored-by: lizihao-anu <[email protected]>
Co-authored-by: Zihao Li <[email protected]>
Co-authored-by: Jennit07 <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-merge-queue[bot] <github-merge-queue[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Megan McNicol <[email protected]>
Co-authored-by: marjom02 <[email protected]>
Co-authored-by: github-merge-queue[bot] <118344674+github-merge-queue[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants