Mm adding new profiles process #88
Conversation
…sly selected sub-tab is unavailable
|
looking good but i've not finished my review yet. You'll see I've pushed a couple of changes, one of which was to check what happens if we have a number of profiles that isn't a multiple of 3. It looks like we just get an empty area - something we may or may not want. I quite like the idea of suggesting whats next - i just dont' want to commit to a child poverty profiles just yet (until i'm sure we have resource to actually work on it). |
|
I made a few tweaks to re-order profiles so they match the current live tool order and replaced a few 'and' with '&' to reduce the length of descriptions. |
|
@abigap01 I forgot to add you as a reviewer for this. Could you please take a look and check if my comments make sense, and that you're able to follow the process for adding a new profile? (I'll email you the SOP now). You just need to look at the global, ui and server script and see if you can follow the comments and broadly make sense of how the new profiles list in the global script is being used to create the landing page buttons and to determine which tabs are hidden/shown for each profile. It would be really helpful to know if there is anything confusing at all, big or small so I can improve the comments for it. Can chat through at our catch up tomorrow too. |
No description provided.