Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

centralise github workflows #105

Merged
merged 1 commit into from
Dec 9, 2024
Merged

centralise github workflows #105

merged 1 commit into from
Dec 9, 2024

Conversation

alan-y
Copy link
Collaborator

@alan-y alan-y commented Dec 8, 2024

No description provided.

@alan-y alan-y added the enhancement New feature or request label Dec 8, 2024
@alan-y alan-y requested a review from Moohan December 8, 2024 20:52
Copy link
Member

@Moohan Moohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Note that because R older than v4.0.0 fails to build / check, the test-coverage action will never run. I'll look at updating that, so that test-coverage runs as long as the latest release check passes.

Is it worth making phstemplates explicitly require >=4.0.0 ? I can't think why it would be needed for old bits of work / code and anything new can quite easily be done on v4.

@alan-y alan-y merged commit 4692e46 into main Dec 9, 2024
2 checks passed
@alan-y alan-y deleted the feature/phs-checks branch December 9, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants