navbar and row changes

[alan-y]

Made some changes to the Shiny CSS file so that the navigation bar covers the whole width of the page and so the heading text in tabpanels lines up with the text in fluid rows. It looks all fine to me when I load up the shiny template but let me know if you think these changes may cause issues thanks.

[Moohan]

I haven't checked the changes yet, but just a note to say we should make sure to update inst/text/phs_style.css inline with this one.

[alan-y]

I haven't checked the changes yet, but just a note to say we should make sure to update inst/text/phs_style.css inline with this one.

phs_style.css is for html, etc while these changes mainly affect Shiny. The user has the option to add the Shiny CSS stuff into phs_style.css when they run the function.

[Moohan]

Looks good to me. Subtle changes but definitely an improvement!

Note I also just checked these using the template - It would be good if someone who has developed a dashboard from the template could try the new CSS with that.

[rubenv95]

Also tested in the template, all fine, but I don't have a full app to test on currently.

I noticed the template is trying to source a script that doesn't exist and was throwing a warning, but that might be a separate issue? The contact page server script doesn't exist in pages/ folder.

remotes::install_github("Public-Health-Scotland/phstemplates", ref = "feature/css-changes")
phstemplates::phsshinyapp("Test/", app_name = "TestApp")
shiny::runApp('Test')
Listening on http://127.0.0.1:5610
Warning in file(filename, "r", encoding = encoding) :
cannot open file 'pages/contact_page.R': No such file or directory
Warning: Error in file: cannot open the connection
40: file
39: source
38: server [/mnt/homes/rubenv01/Test/app.R#86]
1: shiny::runApp
Error in file(filename, "r", encoding = encoding) :
cannot open the connection

[alan-y]

Also tested in the template, all fine, but I don't have a full app to test on currently.

I noticed the template is trying to source a script that doesn't exist and was throwing a warning, but that might be a separate issue? The contact page server script doesn't exist in pages/ folder.

remotes::install_github("Public-Health-Scotland/phstemplates", ref = "feature/css-changes")
phstemplates::phsshinyapp("Test/", app_name = "TestApp")
shiny::runApp('Test')
Listening on http://127.0.0.1:5610
Warning in file(filename, "r", encoding = encoding) :
cannot open file 'pages/contact_page.R': No such file or directory
Warning: Error in file: cannot open the connection
40: file
39: source
38: server [/mnt/homes/rubenv01/Test/app.R#86]
1: shiny::runApp
Error in file(filename, "r", encoding = encoding) :
cannot open the connection

Hi @rubenv95, thanks for testing the template. I just ran the install command above and the app seems to be running fine for me with the contact page on it (I added this as a suggestion on the Shiny template). It seems to me that a lot of people have customised their CSS file for Shiny apps - so I imagine the one we have may not work perfectly for quite a few apps...