Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding the CI workflows #5

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Moohan
Copy link
Member

@Moohan Moohan commented Aug 24, 2022

I'm updating the CI on all the PHS packages.

I updated the pkgdown workflow to be based off of the r-lib actions v2 example.

I've added a workflow and infrastructure to work out and report test coverage to codecov.io

I've added an R-CMD check to use the standard actions from r-lib. It tests against quite a few R versions with an argument to specify whether they are must_pass or not i.e. will the whole workflow fail if they do? The versions of R selected are from a brief chat with Russell and are trying to balance what is available now with what we will have on the new R infrastructure, as well as what any external users might be using...

I've also added workflows to automatically document, style and lint any code. The idea is that these will run on any PR code and resolve any simple issues automatically.

Moohan and others added 7 commits August 24, 2022 14:27
Will run on a collection of R versions which will hopefully capture the PHS current and future set-ups.

Also added a badge to the readme to report the status.
This will check and report how much of the package is covered by the tests. It will report the results to codecov.io as well as commenting on relevant PRs
Will run when any files in the `R` directory are modified and ensure the package documentation is up to date.
This will run whenever a relevant filetype is modified and style the package with `styler` to the tidyverse style.

All the changes will be only cosmetic btu will ensure consistency.
It will run on any push or pull and add annotiations to the commit / PR with suggestions from `lintr` which provides best practice.
@Moohan Moohan changed the title Expand ci Expanding the CI workflows Aug 24, 2022
@Moohan Moohan requested a review from Tina815 December 2, 2022 12:44
@Moohan
Copy link
Member Author

Moohan commented Dec 2, 2022

I'm pretty sure the reason document and style workflows are failing is that this PR is via a fork, so they're running on the PHS/phsstyles repo but need to commit to moohan/phsstyles. It's using the same code as on phsmethods and other repos, so should work fine once it's merged.

@Moohan
Copy link
Member Author

Moohan commented Dec 2, 2022

I'm pretty sure the reason document and style workflows are failing is that this PR is via a fork, so they're running on the PHS/phsstyles repo but need to commit to moohan/phsstyles. It's using the same code as on phsmethods and other repos, so should work fine once it's merged.

It sounds like there is a workaround but it's a bit of a faff, let me know if you want me to try and do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant