-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filtering options to get_dataset
#46
Add filtering options to get_dataset
#46
Conversation
Looks like checks are failing, I need to make the |
eb9de37
to
c83f57f
Compare
I should have stopped with just the row and column filters on I think everything is working now - all the issues I ended up having were to do with me trying to improve / make stricter the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Am wondering about the error handling now that weve switched to retry - for example when trying to select a column that doesn
t exist (or is mistyped) I think the call should fail and return the error message immediately rather than retrying. What do you think?
I needed this for another project, so had a look and realised it was quite simple. This closes #8
I added some tests and spent a bit of time improving the error messages around the checking of the args (
parse_col_select()
andparse_row_filter()
)