Get latest resource #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moohan
requested changes
Jul 16, 2024
Co-authored-by: James McMahon <[email protected]>
Co-authored-by: James McMahon <[email protected]>
Co-authored-by: James McMahon <[email protected]>
Co-authored-by: James McMahon <[email protected]>
Co-authored-by: James McMahon <[email protected]>
Co-authored-by: James McMahon <[email protected]>
Moohan
reviewed
Jul 17, 2024
csillasch
reviewed
Jul 17, 2024
csillasch
requested changes
Jul 31, 2024
Moohan
previously requested changes
Jul 31, 2024
Co-authored-by: James McMahon <[email protected]>
Co-authored-by: James McMahon <[email protected]>
Moohan
reviewed
Aug 1, 2024
There was a problem hiding this comment.
Looks good to me, my only (final) suggestion is that maybe we should always / by default return the context when using this i.e. set include_context = TRUE in the function definition.
Alternatively, include this context information in a message to the user. My concern is that, at the moment it returns a resource, but there's no way for the user to find out what has been returned unless they set include_context = TRUE themselves
Moohan
dismissed
their stale review
Happy, pending my final comment, I'll let @csillasch weigh in / approve.
csillasch
previously approved these changes
Aug 1, 2024
Moohan
previously approved these changes
Aug 1, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a separate pull request to review the get_latest_resource functions I accidently included within the issue10 pull request