Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #20

Merged
merged 3 commits into from
Jan 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/get_dataset.R
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#' \href{https://www.opendata.nhs.scot/}{NHS Open Data platform}
#' @param max_resources (optional) the maximum number of resources
#' to return, use for testing code,
#' it will retunr the n latest resources
#' it will return the n latest resources
#' @param rows (optional) specify the max number of rows
#' to return for each resource.
#'
Expand Down Expand Up @@ -68,7 +68,7 @@
)

# of matching name cols, find if types match too
inconsistent_index <- this_types[matching_names] != next_types[matching_names]

Check warning on line 71 in R/get_dataset.R

View workflow job for this annotation

GitHub Actions / lint

file=R/get_dataset.R,line=71,col=81,[line_length_linter] Lines should not be more than 80 characters. This line is 82 characters.
inconsistencies[[i]] <- this_types[matching_names][inconsistent_index]
}

Expand All @@ -79,7 +79,7 @@
if (length(to_coerce) > 0) {
cli::cli_warn(c(
"Due to conflicts between column types across resources,
the following {cli::qty(to_coerce)} column{?s} ha{?s/ve} been coerced to type character:",

Check warning on line 82 in R/get_dataset.R

View workflow job for this annotation

GitHub Actions / lint

file=R/get_dataset.R,line=82,col=81,[line_length_linter] Lines should not be more than 80 characters. This line is 96 characters.
"{.val {to_coerce}}"
))
}
Expand Down
2 changes: 1 addition & 1 deletion R/get_resource_sql.R
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#'
#'
#' Column names must be double-quoted,
#' while character values in filters must be single-quoated.
#' while character values in filters must be single-quoted.
#' e.g.,
#'
#' ```"Age" = '34'```
Expand All @@ -25,7 +25,7 @@
#'
#' ```sql = "SELECT * FROM \"<res_id>\" WHERE \"Age\" = '34'"```.
#'
#' @seealso [get_resource()] for downloading a resource without using a SQL query.

Check warning on line 28 in R/get_resource_sql.R

View workflow job for this annotation

GitHub Actions / lint

file=R/get_resource_sql.R,line=28,col=81,[line_length_linter] Lines should not be more than 80 characters. This line is 82 characters.
#'
#' @importFrom magrittr %>%
#' @return a [tibble][tibble::tibble-package] with the query results.
Expand Down
2 changes: 1 addition & 1 deletion man/get_dataset.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/get_resource_sql.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading