Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cran-comments #124

Merged
merged 2 commits into from
Dec 8, 2023
Merged

update cran-comments #124

merged 2 commits into from
Dec 8, 2023

Conversation

Tina815
Copy link
Contributor

@Tina815 Tina815 commented Dec 1, 2023

No description provided.

@Tina815 Tina815 requested a review from Moohan December 1, 2023 14:18
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d3dd44a) 97.40% compared to head (f57f6ad) 97.40%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files          13       13           
  Lines         424      424           
=======================================
  Hits          413      413           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Moohan Moohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will also need to do reverse dependency checks and then add this to the CRAN comments - https://r-pkgs.org/release.html#sec-release-revdep-checks

This should be fairly simple as I don't think phsmethods has any reverse dependencies yet!

usethis::use_revdep()
revdep_check(num_workers = as.integer(parallelly::availableCores()))

Then paste the contents of revdep/cran.md into cran-comments.md.

@Tina815 Tina815 merged commit 0d02fbf into master Dec 8, 2023
16 checks passed
@Tina815 Tina815 deleted the submit-cran branch December 8, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants