Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test snapshots #116

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Fix test snapshots #116

merged 3 commits into from
Oct 31, 2023

Conversation

Moohan
Copy link
Member

@Moohan Moohan commented Oct 30, 2023

There were some minor changes in the latest version of testthat https://testthat.r-lib.org/news/index.html#testthat-320 which changed how snapshots display warnings and errors.

There were also some changes in the latest version(s) of R - https://cran.r-project.org/doc/manuals/r-release/NEWS.html which were causing the (test-rename.R) snapshots to render differently on different versions.

Due to minor changes in testthat
@Moohan Moohan requested a review from Tina815 October 30, 2023 17:55
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #116 (28ef405) into master (a8cb369) will not change coverage.
The diff coverage is n/a.

❗ Current head 28ef405 differs from pull request most recent head 9895fcb. Consider uploading reports for the commit 9895fcb to get more accurate results

@@           Coverage Diff           @@
##           master     #116   +/-   ##
=======================================
  Coverage   97.30%   97.30%           
=======================================
  Files          13       13           
  Lines         408      408           
=======================================
  Hits          397      397           
  Misses         11       11           

@Moohan
Copy link
Member Author

Moohan commented Oct 31, 2023

@Tina815 I think this is now resolved by 9895fcb It seems like it was just the release and devel versions which were failing, so I think that means it's down to something that has changed between R version 2.3 and 3.1 but I checked https://cran.r-project.org/doc/manuals/r-release/NEWS.html and couldn't see anything...

@Moohan Moohan changed the title Accept new snapshots Fix test snapshots Oct 31, 2023
@Tina815 Tina815 merged commit 9e53056 into master Oct 31, 2023
16 checks passed
@Tina815 Tina815 deleted the testthat-new branch October 31, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants