Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R packages tina #22

Open
wants to merge 3 commits into
base: r-packages
Choose a base branch
from
Open

R packages tina #22

wants to merge 3 commits into from

Conversation

Tina815
Copy link
Contributor

@Tina815 Tina815 commented Oct 7, 2022

I wrote the section "Structure of an R package" and "Writing Documentation".

@Tina815 Tina815 requested review from rmccreath and daikman October 7, 2022 13:39
@Tina815 Tina815 changed the base branch from master to r-packages October 7, 2022 13:39
rmccreath
rmccreath approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@rmccreath rmccreath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @Tina815 - looking good, I made a couple of changes around styling/formatting/typo fixes but nothing of note.

daikman
daikman approved these changes Oct 14, 2022
View reviewed changes
Copy link

@daikman daikman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tina815 . The content looks good! I think we could add an example of what package checks look like to the package checks section. But I have approved these changes anyway.

@fraserstirrat
Copy link

All looks good to me, tested some code on R studio with no issues

fraserstirrat
fraserstirrat approved these changes Mar 21, 2023
View reviewed changes
Copy link

@fraserstirrat fraserstirrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me, tested some code on R studio with no issues (November)
(Old pull request, closing this off.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fraserstirrat fraserstirrat fraserstirrat approved these changes

@daikman daikman daikman approved these changes

@rmccreath rmccreath rmccreath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tina815 @fraserstirrat @rmccreath @daikman