Made login height 100% (#122)

* Made login height 100% * Removed fixed height * Fixed requestBalance unexpected behavior Co-authored-by: Tomas Rocchi <[email protected]>
Psychedelic · Jul 21, 2021 · 49df33d · 49df33d
1 parent deb87c8
commit 49df33d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/source/Background/Controller.js b/source/Background/Controller.js
@@ -159,12 +159,13 @@ backgroundController.exposeController(
   'requestBalance',
   async (opts, metadata, accountId) => secureController(opts.callback, async () => {
     const { callback, message, sender } = opts;
-
     storage.get('apps', async (state) => {
       if (
         state?.apps?.[metadata.url]?.status === CONNECTION_STATUS.accepted
       ) {
-        if (!keyring.isUnlocked) {
+        if (Number.isNaN(parseInt(accountId, 10))) {
+          callback(ERRORS.CLIENT_ERROR('Invalid account id'), null);
+        } else if (!keyring.isUnlocked) {
           const url = qs.stringifyUrl({
             url: 'notification.html',
             query: {

diff --git a/source/Popup/Views/Login/styles.js b/source/Popup/Views/Login/styles.js
@@ -2,7 +2,7 @@ import { makeStyles } from '@material-ui/core/styles';
 
 export default makeStyles((theme) => ({
   root: {
-    height: 552,
+    height: '100%',
     display: 'flex',
     flexDirection: 'column',
     justifyContent: 'space-between',

diff --git a/source/ui/IncomingAction/styles.js b/source/ui/IncomingAction/styles.js
@@ -13,7 +13,6 @@ export default makeStyles((theme) => ({
     justifyContent: 'space-between',
     flexDirection: 'column',
     alignItems: 'center',
-    height: 120,
     marginBottom: `${theme.spacing(3)}px`,
   },
   title: {