Checking storage permission before downloading pem

Psychedelic · Nov 14, 2022 · 53f76a3 · 53f76a3
1 parent 37eff93
commit 53f76a3
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 3 deletions.
diff --git a/android/app/src/main/AndroidManifest.xml b/android/app/src/main/AndroidManifest.xml
@@ -5,7 +5,7 @@
     <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
     <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
     <uses-permission android:name="android.permission.DOWNLOAD_WITHOUT_NOTIFICATION" />
-   <uses-permission android:name="android.permission.MANAGE_DOCUMENTS"/>
+    <uses-permission android:name="android.permission.MANAGE_DOCUMENTS"/>
 
     <application
       android:name=".MainApplication"

diff --git a/src/screens/tabs/Profile/modals/ExportPem/index.tsx b/src/screens/tabs/Profile/modals/ExportPem/index.tsx
@@ -20,6 +20,7 @@ import useCustomToast from '@/hooks/useCustomToast';
 import { Wallet } from '@/interfaces/redux';
 import { useAppDispatch, useAppSelector } from '@/redux/hooks';
 import { getPemFile, validatePassword } from '@/redux/slices/keyring';
+import { requestStoragePermissions } from '@/utils/filesystem';
 import shortAddress from '@/utils/shortAddress';
 
 import styles from './styles';
@@ -64,7 +65,7 @@ function ExportPem({ modalRef }: Props) {
     );
   };
 
-  const handleExportPem = () => {
+  const downloadPem = () => {
     dispatch(
       getPemFile({
         walletId: selectedWallet.walletId,
@@ -111,6 +112,19 @@ function ExportPem({ modalRef }: Props) {
     );
   };
 
+  const handleExportPem = async () => {
+    if (isIos) {
+      downloadPem();
+    } else {
+      await requestStoragePermissions(() => {
+        toast.showError(
+          t('exportPem.permissionError.title'),
+          t('exportPem.permissionError.message')
+        );
+      }, downloadPem);
+    }
+  };
+
   const renderAccount = (account: Wallet) => {
     const { name, walletId, icon, principal } = account;
     const selected = selectedWallet.walletId === walletId;

diff --git a/src/translations/en/index.js b/src/translations/en/index.js
@@ -353,6 +353,10 @@ const translations = {
       message:
         'There was an error while exporting the account. Please try again.',
     },
+    permissionError: {
+      title: 'Error Exporting Account',
+      message: 'You need to allow the app to access storage to save the file.',
+    },
     success: {
       title: 'Account Successfully Exported',
       messageIos: 'Your .pem file should be located at the choosen directory.',

diff --git a/src/utils/filesystem.ts b/src/utils/filesystem.ts
@@ -6,7 +6,7 @@ import { isAndroid, isIos } from '@/constants/platform';
 
 import { getExtension } from './fileTypes';
 
-const requestStoragePermissions = async (
+export const requestStoragePermissions = async (
   onError?: () => void,
   onSuccess?: () => void
 ) => {