Hashes - ARC-81 #2588
Draft
Hashes - ARC-81 #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0cd
reviewed
Jan 18, 2025
| .fold(0, |acc, (i, bit)| if bit.eject_value() { acc | (1 << i) } else { acc }); | ||
|
|
||
| let value = console::types::U8::new(value); | ||
| circuit::Plaintext::Literal( |
There was a problem hiding this comment.
I don't believe this circuit is constrained sufficiently. You'll need to use the from_bits and to_bits utilities.
d0cd
reviewed
Jan 18, 2025
| @@ -256,14 +462,9 @@ impl<N: Network, const VARIANT: u8> HashInstruction<N, VARIANT> { | |||
| (_, PlaintextType::Struct(..)) => bail!("Cannot hash into a struct"), | |||
| (_, PlaintextType::Array(..)) => bail!("Cannot hash into an array (yet)"), | |||
| }; | |||
| // Cast the output to the destination type. | |||
| let output = match self.destination_type { | |||
There was a problem hiding this comment.
Generally, it would nice to have fewer deltas on the variants that are not being changed.
|
Thanks @anstylian for taking an attempt at ARC-81! I think this approach will need careful consideration before we move forward. Specifically we'd like to:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request introduces changes to the Hash instructions in the
synthesizer/program/src/logic/instruction/operation/hash.rsfile. The main focus is on improving the handling of destination types and adding support for additional array types in hashing operations (sha3 and keccak).It is a step forward for the implementation of ARC-81.
Test Plan
Let me know how you prefer to test this