-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document monorepo migration #46
Open
gabor-meszaros
wants to merge
2
commits into
ProtonMail:main
Choose a base branch
from
gabor-meszaros:chore/monorepo-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Document monorepo migration #46
gabor-meszaros
wants to merge
2
commits into
ProtonMail:main
from
gabor-meszaros:chore/monorepo-migration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuthix
reviewed
Dec 16, 2024
Comment on lines
+62
to
+78
## Code contribution | ||
|
||
We are grateful if you can contribute directly with code. In that case there is nothing else to do than to open a pull request. | ||
|
||
The following is worthwhile noting | ||
|
||
- The project is primarily developed on an internal repository, and the one on GitHub is only a mirror of it. For that reason, the merge request will not be merged on GitHub but added to the project internally. We are keeping the original author in the change set to respect the contribution. | ||
- The application is used on numerous platforms. To have higher chance your change to be accepted, consider all supported dependencies. | ||
- Give detailed description of the issue, preferably with test steps to reproduce the original issue, and to verify the fix. It is even better if you also extend the automated tests. | ||
|
||
### Contribution policy | ||
|
||
By making a contribution to this project: | ||
|
||
1. You assign any and all copyright related to the contribution to Proton AG; | ||
2. You certify that the contribution was created in whole by you; | ||
3. You understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information you submit with it) is maintained indefinitely and may be redistributed with this project or the open source license(s) involved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not applicable here IMHO.. If we want to moderate we should specify in monorepo
Suggested change
## Code contribution | |
We are grateful if you can contribute directly with code. In that case there is nothing else to do than to open a pull request. | |
The following is worthwhile noting | |
- The project is primarily developed on an internal repository, and the one on GitHub is only a mirror of it. For that reason, the merge request will not be merged on GitHub but added to the project internally. We are keeping the original author in the change set to respect the contribution. | |
- The application is used on numerous platforms. To have higher chance your change to be accepted, consider all supported dependencies. | |
- Give detailed description of the issue, preferably with test steps to reproduce the original issue, and to verify the fix. It is even better if you also extend the automated tests. | |
### Contribution policy | |
By making a contribution to this project: | |
1. You assign any and all copyright related to the contribution to Proton AG; | |
2. You certify that the contribution was created in whole by you; | |
3. You understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information you submit with it) is maintained indefinitely and may be redistributed with this project or the open source license(s) involved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Proton Mail Desktop app code was moved to WebClients. This hasn't been documented here that leads to confusion.
A contributing guideline is also added to help our users to know how to reach us.