This repository has been archived by the owner on Aug 17, 2023. It is now read-only.
forked from puppetlabs/puppetlabs-ntp
-
Notifications
You must be signed in to change notification settings - Fork 0
Update to last 3.8-compatible commit #1
Open
Alveel
wants to merge
228
commits into
master
Choose a base branch
from
update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The puppet_facts gem implicitly depends on the json gem. On Ruby 1.8.7, json is not built in. On Puppet 2.7, it is not explicitly pulled in by the hiera gem. So we add it here explicitly.
Update .travis.yml, Gemfile, Rakefile, and CONTRIBUTING.md
Add metadata summary per FM-1523
Add IntelliJ files to the ignore list
Removing equal sign as delimiter in ntp.conf for the logfile parameter. Adding documentation of logfile parameter in README.
Set package_manage to false on FreeBSD by default.
…parameter (MODULES-1479) Add package_manage parameter
these restrictions are needed if you want to install an ntpd that only acts as a client 1) disable global acces 2) allow localhost completly (usefull for just in time config changes via cli) 3) allow minimal access to the source servers everything for IPv4 and IPv6 settings are based on http://support.ntp.org/bin/view/Support/AccessRestrictions more and more reflectd NTP attackes are commen on the internet, so it is pretty dangerous to install a simple client without these settings. I guess they could be usefull for other people. fix typo
extend Readme for a simple client
…_logfile_parameter Fixing logfile parameter.
These tests are better covered by the existing unit tests.
add the two options "broadcastclient" and "disable auth"
adjust the expression to ensure `127.127.1.0` is set only if target is running under virtual environment or `udlc` is set. if `server` pointed to `127.127.1.0` without `preferred_servers` settings, it would try to sync with itself but not to the `server`.
Pin rspec gems
1. Removed the "what this affects" section. 2. Made sure each parameter lists a data type and a default value. 3. Made sure the links in the README work and are accurate. 4. Updated the link in the Contributing section to point here: https://docs.puppetlabs.com/forge/contributing.html 5. Updated the Limitations section to link to the list of supported platforms. 6. General copyediting.
Updates the README file
Removed a subsection with my last update; forgot to update the table of contents. Phooey.
Update the README Table of Contents
Broadcast and auth
fix `is_virtual` detection issue
Stdlib 4.0.0 allows str2bool to take a bool as an argument; unfortunately ntp still claims to work with stdlib >= 3.2.0
The UDLC should really only be used on machines with accurate clocks, and this logic was reversed incorrectly. This PR also allows the udlc setting to be overridden, whereas before it was not.
(MODULES-1796) Fix stdlib 3.2.0 compatibility
Fix PR puppetlabs#235 and make udlc configurable
{maint} modulesync 0794b2c
(MODULES-3581) modulesync [067d08a]
(MAINT) Update for modulesync_config 72d19f184
(FM-5470) add is reset-failed for systemd, on test
(MAINT) Update NOTICE to new company name
Update modulesync_config [a3fe424]
…readme [MAINT] Update README to amend incorrect package_name description
Letting the template file path get set is disruptive to environment based test workflows, causing unnecessary events each time one switches environment, e.g.: Notice: /Stage[main]/Ntp::Config/File[/etc/ntp/keys]/content: --- /etc/ntp/keys 2016-09-23 14:36:07.000000000 +0200 +++ /tmp/puppet-file20160923-14521-1j0zq8t 2016-09-23 20:16:06.000000000 +0200 @@ -1,4 +1,4 @@ # THIS FILE IS MANAGED BY PUPPET -# /etc/puppet/environments/production/puppet/forge/ntp/templates/keys.erb +# /etc/puppet/environments/foo/puppet/forge/ntp/templates/keys.erb #
This patch keeps the existing behavior for environments without preferred servers. For environments with preferred servers step-tickers now only contains the preferred ntp sources.
Remove path to template file from keys.erb
MODULES-3898 - ntp step-tickers should honor preferred servers
rspec-puppet-facts is now provided by the default modulesync configs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.