Fix: Anime list columns expanded to full width #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2021
|
Can you go through the process @singhayushh what you have been working on |
singhayushh
commented
Mar 25, 2021
| popularList: popularList, | ||
| ongoingList: ongoingList, | ||
| }); | ||
| setTimeout(function(){ |
There was a problem hiding this comment.
Previously, since the render method for home page was working concurrently with the other web scraping functions, the home page was getting rendered before the fetching of ongoing anime list was complete.
Here, I have added a simple timeout of 3 seconds for the render home page function. This 3 second delay is enough for the web scraping functions to complete before the rendering happens - thus solving the issue.
singhayushh
commented
Mar 25, 2021
| @@ -14,7 +14,7 @@ | |||
| <div class="page-single"> | |||
| <div class="container"> | |||
| <div class="row ipad-width2"> | |||
| <div class="col-md-8 col-sm-12 col-xs-12"> | |||
| <div class="col-md-8 col-sm-12 col-xs-12" style="width: 100%"> | |||
There was a problem hiding this comment.
This is just a small change in css of the anime list columns. They were pushed to the left hand side of the screen previously, as mentioned in issue #12.
yasharth291
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue: #12
Changes
I had initially proposed to center the columns, but expanding them to full width looks even better.
Note
As PR #16 and this PR have relatively lesser change of code, I have merged the two commits together, so merging this PR will merge #16 automatically.
Screenshot for reference
