Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMS Revisions - Foundations: Populate its all the notebooks. Also update README for the whole cookbook accordingly #24

Merged
merged 2 commits into from
Dec 17, 2024
Merged

AMS Revisions - Foundations: Populate its all the notebooks. Also update README for the whole cookbook accordingly #24

merged 2 commits into from
Dec 17, 2024

Conversation

erogluorhan
Copy link
Member

@erogluorhan erogluorhan commented Dec 17, 2024 •
edited
Loading

Closes #16.

  • Updates each notebook to make them more generic/foundational by limiting the mentioning of UXarray significantly
  • Also updates README accordingly with the whole new Cookbook structure
  • Adds a png file for the first notebook
  • Does not remove the older notebooks for now just in case they'd still be used for the rest of the revisions

@erogluorhan erogluorhan requested a review from philipc2 December 17, 2024 19:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: f7b3bb8
✅ Deployment Preview URL: https://ProjectPythia.github.io/unstructured-grid-viz-cookbook/_preview/24

@erogluorhan erogluorhan mentioned this pull request Dec 17, 2024
Closed
philipc2
philipc2 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@philipc2 philipc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great!

@philipc2 philipc2 merged commit 1b64648 into ams-revisions Dec 17, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
@philipc2 @github-actions
Delete preview for pull request \#24
f81202c
@erogluorhan erogluorhan deleted the ams-revisions-foundations branch December 17, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipc2 philipc2 philipc2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erogluorhan @philipc2