Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update environment.yml #12

Merged
merged 4 commits into from
May 1, 2024
Merged

Update environment.yml #12

merged 4 commits into from
May 1, 2024

Conversation

erogluorhan
Copy link
Member

Update environment.yml to:

  • Revert installation of uxarray from the main branch to conda relases
  • Remove jupyter_server per this

@erogluorhan erogluorhan requested a review from philipc2 April 30, 2024 16:38
Copy link

github-actions bot commented Apr 30, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: eb18f3e
✅ Deployment Preview URL: https://ProjectPythia.github.io/unstructured-grid-viz-cookbook/_preview/12

@erogluorhan
Copy link
Member Author

Hey @philipc2 you may want to see the error in the book build process as it maybe related to April's release

@philipc2
Copy link
Collaborator

Hey @philipc2 you may want to see the error in the book build process as it maybe related to April's release

Taking a look at it!

@philipc2
Copy link
Collaborator

Previously, we were raising a warning when the user attending to do uxds.plot(), however now we are raising an exception with a more detailed

Before

image

After

image

I wonder what the correct way to show off an exception is in a notebook without it breaking the build?

@erogluorhan
Copy link
Member Author

Previously, we were raising a warning when the user attending to do uxds.plot(), however now we are raising an exception with a more detailed

Before

image

After

image

I wonder what the correct way to show off an exception is in a notebook without it breaking the build?

Got it!

I don't know if there is a correct one among multiple ways to do this. One immediate way would be to put a try-catch block into that cell (don't know if it would look elegant though), and print something out of the cell in the catch to show there was an exception.

@philipc2
Copy link
Collaborator

Previously, we were raising a warning when the user attending to do uxds.plot(), however now we are raising an exception with a more detailed

Before

image

After

image
I wonder what the correct way to show off an exception is in a notebook without it breaking the build?

Got it!

I don't know if there is a correct one among multiple ways to do this. One immediate way would be to put a try-catch block into that cell (don't know if it would look elegant though), and print something out of the cell in the catch to show there was an exception.

Yeah, I thought of the try-catch, but from a readers perspective it might be confusing.

Maybe we don't need to run uxds.plot() and we could just document it in the markdown?

@erogluorhan
Copy link
Member Author

Yeah, I thought of the try-catch, but from a readers perspective it might be confusing.

Maybe we don't need to run uxds.plot() and we could just document it in the markdown?

How about commenting that out and putting a comment before it to say running that line would show the exception? If this makes sense, I can add it to this PR

@philipc2
Copy link
Collaborator

philipc2 commented May 1, 2024

Yeah, I thought of the try-catch, but from a readers perspective it might be confusing.
Maybe we don't need to run uxds.plot() and we could just document it in the markdown?

How about commenting that out and putting a comment before it to say running that line would show the exception? If this makes sense, I can add it to this PR

That sounds like a great idea, go ahead and include it in this PR!

@erogluorhan
Copy link
Member Author

erogluorhan commented May 1, 2024

Yeah, I thought of the try-catch, but from a readers perspective it might be confusing.
Maybe we don't need to run uxds.plot() and we could just document it in the markdown?

How about commenting that out and putting a comment before it to say running that line would show the exception? If this makes sense, I can add it to this PR

That sounds like a great idea, go ahead and include it in this PR!

Done! Feel free to give it a review now that we got the build fixed (Added two more commits to sort the bullet points in the Why UXarray? part, but that's it, there will not be any more commits I believe)

Copy link
Collaborator

@philipc2 philipc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good!

@philipc2 philipc2 merged commit f47475b into main May 1, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request May 1, 2024
@erogluorhan erogluorhan deleted the update-env branch December 17, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants