Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link about lunar day, and remove dead link to NASA dataset interoperability #495

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

brian-rose
Copy link
Member

Closes #494

@brian-rose brian-rose requested a review from a team as a code owner October 23, 2024 19:26
@brian-rose brian-rose requested review from dopplershift and r-ford and removed request for a team October 23, 2024 19:26
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Oct 23, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 7854556
✅ Deployment Preview URL: https://ProjectPythia.github.io/pythia-foundations/_preview/495

@brian-rose
Copy link
Member Author

There's another broken link now... will try to fix.

@brian-rose
Copy link
Member Author

I removed a link in the final "References" section of the NetCDF notebook. The link was to something related to NASA dataset interoperability recommendations for earth science. I'm not sure exactly what was linked. A google search on this topic yielded a number of different technical documents, but it wasn't clear to me that there was a lot of value in promoting these as recommended follow-up reading for our chapter.

@brian-rose brian-rose changed the title Fix broken link about lunar day Fix broken link about lunar day, and remove dead link to NASA dataset interoperability Oct 23, 2024
@dopplershift
Copy link
Contributor

Looks like this contains the recommendations extracted from the original. Not sure if it's worth linking.

@brian-rose
Copy link
Member Author

Not sure if it's worth linking.

In my opinion, no. It's a technical report from a technical working group, not a tutorial document.

@dopplershift dopplershift merged commit 030b86c into ProjectPythia:main Oct 24, 2024
3 checks passed
@brian-rose brian-rose deleted the fix-link branch November 19, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link causing nightly build failure
2 participants