Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language edits in the Introduction section of the Core Package Overview #457

Merged
merged 6 commits into from
Apr 10, 2024

Conversation

himahuja
Copy link
Contributor

@himahuja himahuja commented Apr 6, 2024

The current introduction talks about a stack. I understand the intention of teaching new students a lingo, but no overview of libraries is given. My current edits can help students get an understanding of what content follows.

Please also note that I added "... libraries (or packages)", because the following tutorials use these terms interchangeably, and I think this is a good place to equate these terms.

himahuja added 3 commits April 2, 2024 23:44
The current introduction talks about a stack. I understand the intention of teaching new students a lingo, but no overview about libraries is given. My current edit can help students get an understanding of what content follows.
This reverts commit 50afbdb.
@himahuja himahuja requested a review from a team as a code owner April 6, 2024 22:08
@himahuja himahuja requested review from ktyle and dcamron and removed request for a team April 6, 2024 22:08
Copy link

github-actions bot commented Apr 6, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: cfb4718
✅ Deployment Preview URL: https://ProjectPythia.github.io/pythia-foundations/_preview/457

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@dcamron dcamron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes are clean, and absolutely appreciated. Thank you for the submission!

Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, these are very helpful edits and everything is good to go! Thanks @himahuja

@brian-rose brian-rose merged commit e8ff5e2 into ProjectPythia:main Apr 10, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants