Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tutorial content videos #147

Merged
merged 48 commits into from
Sep 30, 2021
Merged

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Sep 9, 2021

Adding cards for tutorial video recordings to resource gallery.

See:
#146
ProjectPythia/pythia-foundations#118

@jukent jukent requested a review from a team as a code owner September 9, 2021 19:09
@jukent jukent requested review from kmpaul and dcamron September 9, 2021 19:09
@jukent
Copy link
Contributor Author

jukent commented Sep 9, 2021

blackdock is failing with a ModuleNotFound Error -- toml

blackdoc.................................................................Failed
- hook id: blackdoc
- exit code: 1

Traceback (most recent call last):
  File "/home/runner/.cache/pre-commit/repoqsdzclid/py_env-python3/bin/blackdoc", line 5, in <module>
    from blackdoc.__main__ import main
  File "/home/runner/.cache/pre-commit/repoqsdzclid/py_env-python3/lib/python3.9/site-packages/blackdoc/__main__.py", line 12, in <module>
    from .blackcompat import (
  File "/home/runner/.cache/pre-commit/repoqsdzclid/py_env-python3/lib/python3.9/site-packages/blackdoc/blackcompat.py", line 9, in <module>
    import toml
ModuleNotFoundError: No module named 'toml'

@keewis
Copy link

keewis commented Sep 11, 2021

you can fix that by running pre-commit autoupdate --repo blackdoc (v0.3.3 and below didn't declare toml as a explicit dependency)

@jukent
Copy link
Contributor Author

jukent commented Sep 13, 2021

you can fix that by running pre-commit autoupdate --repo blackdoc (v0.3.3 and below didn't declare toml as a explicit dependency)

Can you say more? I ran the above command on my local fork and nothing happened. I had to install pre-commit first.

@keewis
Copy link

keewis commented Sep 14, 2021

The only thing it does is upgrade the version from v0.3.3 to v0.3.4, which you can do manually by editing .pre-commit-config.yaml (sorry for making this more complicated than it really is)

@jukent
Copy link
Contributor Author

jukent commented Sep 23, 2021

Fixed the truncating of html issue (that was affecting the modal buttons) with this code from @eentzel https://github.com/eentzel/htmltruncate.py/blob/master/htmltruncate.py and help from @kmpaul :)

@jukent
Copy link
Contributor Author

jukent commented Sep 23, 2021

@clyne All of the tutorial video cards now have the link to the static content in their description!
This had an unexpected hiccup that has been fixed with the new _extensions/truncatehtml.py file.

Copy link
Collaborator

@kmpaul kmpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured out how to truncate on words (or really to cut on blank spaces). If you implement the suggestion, it should work.

portal/_extensions/truncatehtml.py Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2021

This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below.

🔍 Git commit SHA: 09a032c
✅ Deployment Preview URL: https://6154d4854d118614cbb8b990--projectpythia-org.netlify.app

@jukent jukent requested a review from kmpaul September 27, 2021 14:54
Copy link
Contributor

@clyne clyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @jukent. One typo and one question:

On all of the cards "conent" should be "content"

Do we still have an open issue to provide a means to showcase [filter] all of the Pythia created videos so that we can, for example, add something to our main landing page that says something like "Recorded Project Pythia" tutorials, gives a brief description, and then provides a link to all of the Pythia created videos?

@jukent
Copy link
Contributor Author

jukent commented Sep 29, 2021

Good catch! Just fixed that now.

Yes I think creating that new page would be a great place idea. I can create the issue for it but am about to take some PTO until late October - so someone might want to move forward on that sooner than that.

@jukent jukent requested a review from clyne September 29, 2021 20:59
@clyne
Copy link
Contributor

clyne commented Sep 29, 2021

Good catch! Just fixed that now.

Yes I think creating that new page would be a great place idea. I can create the issue for it but am about to take some PTO until late October - so someone might want to move forward on that sooner than that.

Yes, it would be great if you can open an issue. Enjoy your PTO!

@jukent
Copy link
Contributor Author

jukent commented Sep 29, 2021

@clyne Do you think this new issue is the same as or similar to #157 ?

@kmpaul
Copy link
Collaborator

kmpaul commented Sep 29, 2021

I think it's the same, but you should make a note of what you are doing in that issue and cross-reference to this.

@clyne
Copy link
Contributor

clyne commented Sep 29, 2021

@clyne Do you think this new issue is the same as or similar to #157 ?

Yes! Sorry I missed it. I scanned the issues earlier but somehow overlooked this one. Thanks!

@jukent
Copy link
Contributor Author

jukent commented Sep 30, 2021

@kmpaul Could you approve this? Your changes are still marked as "requested" even though they're resolved. Would love to merge this soon.

Copy link
Collaborator

@kmpaul kmpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, @jukent!

@jukent jukent merged commit ba5c375 into ProjectPythia:main Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants