-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tutorial content videos #147
Conversation
|
you can fix that by running |
Can you say more? I ran the above command on my local fork and nothing happened. I had to install |
The only thing it does is upgrade the version from |
Fixed the truncating of html issue (that was affecting the modal buttons) with this code from @eentzel https://github.com/eentzel/htmltruncate.py/blob/master/htmltruncate.py and help from @kmpaul :) |
@clyne All of the tutorial video cards now have the link to the static content in their description! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured out how to truncate on words (or really to cut on blank spaces). If you implement the suggestion, it should work.
Co-authored-by: Kevin Paul <[email protected]>
This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below. 🔍 Git commit SHA: 09a032c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @jukent. One typo and one question:
On all of the cards "conent" should be "content"
Do we still have an open issue to provide a means to showcase [filter] all of the Pythia created videos so that we can, for example, add something to our main landing page that says something like "Recorded Project Pythia" tutorials, gives a brief description, and then provides a link to all of the Pythia created videos?
Good catch! Just fixed that now. Yes I think creating that new page would be a great place idea. I can create the issue for it but am about to take some PTO until late October - so someone might want to move forward on that sooner than that. |
Yes, it would be great if you can open an issue. Enjoy your PTO! |
I think it's the same, but you should make a note of what you are doing in that issue and cross-reference to this. |
@kmpaul Could you approve this? Your changes are still marked as "requested" even though they're resolved. Would love to merge this soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks, @jukent!
Adding cards for tutorial video recordings to resource gallery.
See:
#146
ProjectPythia/pythia-foundations#118