Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom domain name option #135

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Remove custom domain name option #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 1 addition & 19 deletions .github/workflows/deploy-book.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@ on:
required: false
default: 'false'
type: string
cname:
description: 'Custom domain name'
required: false
default: 'None' # This is just a flag for whether to ignore this input
type: string
publish_dir:
description: 'Publish dir for the action'
required: false
Expand Down Expand Up @@ -64,24 +59,11 @@ jobs:
- name: Deploy to GitHub Pages
uses: JamesIves/github-pages-deploy-action@v4
if: |
(github.ref == 'refs/heads/main' && inputs.cname == 'None')
with:
token: ${{ secrets.GITHUB_TOKEN }}
branch: gh-pages
folder: ${{ inputs.publish_dir }}
clean: true
clean-exclude: _preview/* # keep existing previews from other PRs
target-folder: ${{ inputs.destination_dir }}

- name: Deploy to GitHub Pages with custom domain
uses: JamesIves/github-pages-deploy-action@v4
if: |
(github.ref == 'refs/heads/main' && inputs.cname != 'None')
(github.ref == 'refs/heads/main')
with:
token: ${{ secrets.GITHUB_TOKEN }}
branch: gh-pages
folder: ${{ inputs.publish_dir }}
clean: true
clean-exclude: _preview/* # keep existing previews from other PRs
target-folder: ${{ inputs.destination_dir }}
CNAME: ${{ inputs.cname }} # how can we set this for the new action?