Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: Add new notebook calculating ENSO with intake-esgf #65

Merged
merged 7 commits into from
Oct 18, 2023

Conversation

mgrover1
Copy link
Contributor

@mgrover1 mgrover1 commented Oct 6, 2023

Show how to use intake-esgf to access data, apply ENSO calculations, and visualize using hvPlot.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 39e228a
✅ Deployment Preview URL: https://ProjectPythia.github.io/cmip6-cookbook/_preview/65

@mgrover1 mgrover1 requested review from r-ford and brian-rose October 9, 2023 19:13
@r-ford
Copy link
Member

r-ford commented Oct 10, 2023

Nice! I'll take a look at this today.

It seems like the preview action is failing because the environment is not being updated to include intake_esgf. Is the solution to just update the env on main first, or is there some config option that can be set?

@brian-rose
Copy link
Member

It seems like the preview action is failing because the environment is not being updated to include intake_esgf. Is the solution to just update the env on main first, or is there some config option that can be set?

This is a current limitation of our build actions (ProjectPythia/cookbook-actions#77). This "edge case" of building on Binder with secrets and a change in the environment file is not something we currently handle. There are complications around the scope rules for using secrets that we haven't solved.

The workaround is as Rob says: open a simple PR just adding the new package to the environment file and merge it into main even though it won't build and preview properly. Then proceed with this PR.

@mgrover1
Copy link
Contributor Author

@brian-rose @r-ford - I submitted a PR with the suggested way forward 😄

@r-ford r-ford closed this Oct 11, 2023
@r-ford r-ford reopened this Oct 11, 2023
@mgrover1
Copy link
Contributor Author

@brian-rose - unpinning numpy here brought back the numba issues... I will submit a PR to revert the numpy version.

@mgrover1
Copy link
Contributor Author

@brian-rose @r-ford numba is causing issues with the main execution environment. The opendap issue has been resolved, I am not sure what to do about rebuilding the conda environment for the book here. Those recent PRs did not trigger a reinstallation of numba.

@mgrover1 mgrover1 merged commit 50a7528 into ProjectPythia:main Oct 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants