Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to slim up environment #83

Closed
wants to merge 2 commits into from
Closed

Attempt to slim up environment #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a5c761
put comparison to raw and rm from environment
jukent Dec 19, 2024
21b1caa
chng cells to raw
jukent Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ dependencies:
- metpy
- geocat-viz>=2023.10.0
- colorcet
- hvplot
- plotly
- seaborn
Copy link
Collaborator

@kafitzgerald kafitzgerald Dec 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove seaborn, we'll need to skip xarray 2024.11.0

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't Xarray still install it without us specifying that it needs to be installed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^as a dependency?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug in Xarray 2024.11.0 is that it thinks it needs seaborn in some cases where it actually does not. We have code in here that also hits that bug. That's why the build was failing I think.

- uxarray
- datashader
- geocat-datafiles
Expand Down
30 changes: 18 additions & 12 deletions notebooks/1-comparison.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,10 +270,12 @@
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {},
"outputs": [],
"cell_type": "raw",
"metadata": {
"vscode": {
"languageId": "raw"
}
},
"source": [
"import plotly.express as px\n",
"\n",
Expand All @@ -295,10 +297,12 @@
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {},
"outputs": [],
"cell_type": "raw",
"metadata": {
"vscode": {
"languageId": "raw"
}
},
"source": [
"import seaborn as sns\n",
"sns.set_theme()\n",
Expand Down Expand Up @@ -350,10 +354,12 @@
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {},
"outputs": [],
"cell_type": "raw",
"metadata": {
"vscode": {
"languageId": "raw"
}
},
"source": [
"import pandas as pd\n",
"import hvplot.pandas\n",
Expand Down
Loading