Add payableOverrides to the fulfillOrder method. #363
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional
overrides
parameter tofulfillOrder
. Has the same functionality asoverrides
inmatchOrders
except it will ignorevalue
if provided as that is calculated elsewhere and based on the order.Motivation
I wanted to be able to set my own gasLimit in fulfillOrder and saw someone else had previously made an issue but never finished so I thought I would go ahead.
#82
Solution