Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add payableOverrides to the fulfillOrder method. #363

Merged

Conversation

tenthirtyone
Copy link
Contributor

Adds an optional overrides parameter to fulfillOrder. Has the same functionality as overrides in matchOrders except it will ignore value if provided as that is calculated elsewhere and based on the order.

Motivation

I wanted to be able to set my own gasLimit in fulfillOrder and saw someone else had previously made an issue but never finished so I thought I would go ahead.

#82

Solution

const { actions } = await seaport.fulfillOrder({
  order,
  accountAddress: fulfiller.address,
  domain: OPENSEA_DOMAIN,
  overrides: { gasLimit: overrideGasLimit }, // new feature
});

@ryanio
Copy link
Collaborator

ryanio commented Oct 4, 2023

thanks for opening and adding tests :) we can definitely get this in and also add to opensea-js methods that send out txs

@ryanio
Copy link
Collaborator

ryanio commented Oct 10, 2023

thinking if we should add these overrides in a standard way to all the other functions that send txs, other than just fulfillOrder 🤔

@ryanio ryanio merged commit 1f9f820 into ProjectOpenSea:main Oct 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants