add test case for empty domain tag (#232)

* add test case for empty domain tag * gh actions: remove need for node auth token * bump patch version
ProjectOpenSea · May 9, 2023 · 59bcd77 · 59bcd77
1 parent b51f27e
commit 59bcd77
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 20 deletions.
diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
@@ -6,22 +6,17 @@ on:
       - main
   pull_request:
 
-env:
-  GITHUB_TOKEN: ${{ secrets.GH_PAT_TOKEN }}
-
 jobs:
   lint:
     runs-on: ubuntu-latest
 
     steps:
       - uses: actions/checkout@v3
       - name: Setup Node.js
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v3
         with:
           node-version: 16.11.0
           cache: npm
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.GH_PAT_TOKEN }}
 
       - name: Install dependencies
         run: npm ci --ignore-scripts
@@ -38,12 +33,10 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - name: Setup Node.js
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v3
         with:
           node-version: 16.11.0
           cache: npm
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.GH_PAT_TOKEN }}
 
       - name: Install dependencies
         run: npm ci --ignore-scripts
@@ -60,12 +53,10 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - name: Setup Node.js
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v3
         with:
           node-version: 16.11.0
           cache: npm
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.GH_PAT_TOKEN }}
 
       - name: Install dependencies
         run: npm ci --ignore-scripts

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@opensea/seaport-js",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "[Seaport](https://github.com/ProjectOpenSea/seaport) is a new marketplace protocol for safely and efficiently buying and selling NFTs. This is a JavaScript library intended to make interfacing with the contract reasonable and easy.",
   "license": "MIT",
   "author": "OpenSea Developers",

diff --git a/src/__tests__/fulfill-orders.spec.ts b/src/__tests__/fulfill-orders.spec.ts
@@ -8,6 +8,7 @@ import { ItemType, MAX_INT } from "../constants";
 import { TestERC1155, TestERC721 } from "../typechain";
 import { CreateOrderInput, CurrencyItem } from "../types";
 import * as fulfill from "../utils/fulfill";
+import { getTagFromDomain } from "../utils/usecase";
 import { describeWithFixture } from "./utils/setup";
 
 describeWithFixture(
@@ -849,7 +850,8 @@ describeWithFixture(
               { order: thirdOrder },
             ],
             accountAddress: fulfiller.address,
-            domain: OPENSEA_DOMAIN,
+            // When domain is empty or undefined, it should not append any tag to the calldata.
+            domain: undefined,
           });
 
           const approvalAction = actions[0];
@@ -919,15 +921,18 @@ describeWithFixture(
             transactionMethods: fulfillAction.transactionMethods,
           });
 
-          expect(
-            (
-              await fulfillAction.transactionMethods.buildTransaction()
-            ).data?.slice(-8)
-          ).to.eq(OPENSEA_TAG);
+          // When domain is empty or undefined, it should not append any tag to the calldata.
+          const emptyDomainTag = getTagFromDomain("");
+          const dataForBuildTransaction = (
+            await fulfillAction.transactionMethods.buildTransaction()
+          ).data?.slice(-8);
+          expect(dataForBuildTransaction).to.not.eq(emptyDomainTag);
+          expect(dataForBuildTransaction).to.not.eq(OPENSEA_TAG);
 
           const transaction = await fulfillAction.transactionMethods.transact();
 
-          expect(transaction.data.slice(-8)).to.eq(OPENSEA_TAG);
+          expect(transaction.data.slice(-8)).to.not.eq(emptyDomainTag);
+          expect(transaction.data.slice(-8)).to.not.eq(OPENSEA_TAG);
 
           const balances = await Promise.all([
             testErc1155.balanceOf(offerer.address, nftId),

diff --git a/src/utils/usecase.ts b/src/utils/usecase.ts
@@ -84,10 +84,12 @@ export const getTransactionMethods = <
     const populatedTransaction = await contract.populateTransaction[
       method as string
     ](...[...args, mergedOverrides]);
+
     if (domain) {
       const tag = getTagFromDomain(domain);
       populatedTransaction.data = populatedTransaction.data + tag;
     }
+
     return populatedTransaction;
   };