Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Scourge Map Series export #39

Merged

Conversation

angelic-knight
Copy link
Collaborator

@angelic-knight angelic-knight commented Nov 5, 2021

Abstract

This makes some updates so the map exports can work.

Action Taken

I updated the MapSeriesTiers.dat spec, and the enum of map release versions so that the Scourge map series can be exported.
At a glance, Ritual and Expedition map series exports look okay as well.

Caveats

  • It could be nice to have Scourge in the enum, and rework some code to allow for mapping between Scourge and Hellscape (the name vs the ID of the map series), but I took this simpler approach for now.
  • In this PR, and in all my others up to this point, I have not changed or tested image exports.
  • This may be dependent on changes from 3.16 Export Fixes for Items and Passives #38 in some way. I tested these changes on top of those, but I didn't want all of the changes from 3.16 Export Fixes for Items and Passives #38 in the commits for this PR.

FAO

@pm5k @acbeaumo @Journeytojah

Copy link
Collaborator

@pm5k pm5k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but this should wait for #37 and #38 to be finished with reviews and merged.

@pm5k pm5k merged commit e9e82bc into Project-Path-of-Exile-Wiki:patches Nov 9, 2021
@angelic-knight angelic-knight deleted the patches-maps branch February 1, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants