-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use most common/popular ref and destination #30
Comments
Note that it likely makes sense to have one combined priority list for destinations and ref, since OSRM is mixing the |
Cross-linking #115 (comment) here as another test case for this. |
There is a prototypical implementation in #77 |
Per convo with @1ec5 and @mcwhittemore, there are two separate-but-related issues at play here:
This project is only considering one instruction at a time and translating it, so the decision-making work needs to happen before the instructions make their way into this tool. |
Per my comment above, this tool's job is to take tokens and return the requested sentence using those tokens in a given language. Until/unless this project goes through a significant refactor, any decisionmaking about what tokens get passed into this tool should happen elsewhere. Closing for now. |
Ways can have several
ref
anddestinations
. These are usually;
delimited. Currently we are only always using the first one. Instead, we should use the most common or popular one.As an example, imagine a cross-country road that has the following refs on the way:
I-80
I-80;I-81
I-80;I-81;DETOUR-20
I-80
I-90;I-80
I-90;I-80
I-80
It would be great if the user would always only get
I-80
as the ref.We could implement this via a pre-processing step where we create a priority list (based on occurence, maybe mixed with length of staying on segments) and when deciding for a ref within a way, we should use the one with highest priority.
The text was updated successfully, but these errors were encountered: