-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vary instructions by lane based on destination:lanes #4222
Comments
In the United States, collector-distributor lanes are common in urban areas and at interchanges between freeways. These are often critical junctions where missing a turn could mean a 10-minute detour. OSRM’s current behavior of observing For example, here’s an exit in which the left two lanes (out of five) share a single exit and split shortly thereafter (from Mapillary): The way shared between exits 1B and 1A is tagged:
This route would first take the shared 1B-1A exit, then exit 1A towards 2nd Street (as opposed to I-71). OSRM returns an This is a problem, because the label suggests one subexit and the shield suggests another. The expected behavior would be a The way in question probably should be tagged with |
In this same interchange, a route leading to 2nd Street (exit 1A) ends up saying “take exit 1B” and never says “take exit 1A”. This is due to a combination of factors:
I filed Project-OSRM/osrm-text-instructions#127 for the first issue and #4295 for the second issue. |
Perhaps OSRM Text Instructions could be responsible for varying the instructions based on |
@1ec5 when exposing |
I think OSRM Text Instructions could make use of a raw
If both lanes are valid, as indicated in the Intersection object, then OSRM Text Instructions could pick |
Here's a case of a collector-distributor where adding lanes wouldn't help: I'm not sure this was proposed as such, but this wouldn't be an alternative for Project-OSRM/osrm-text-instructions#30. |
I agree, Project-OSRM/osrm-text-instructions#30 would be desirable for precisely the situation you describe. This issue tracks a related but distinct feature, in which we not only include the most relevant ref and destination but also vary the suggested lanes, which will affect the instruction as well (“Use the second lane from the right to take the ramp…”). |
As an alternative to implementing the proposed logic in OSRM-backend, the /ref #3281 (comment) |
A route step’s
instruction
anddestinations
should account for thedestination:lanes
anddestination:ref:lanes
tags when present. Consider the following scenario:with this collector-distributor way:
If the route travels to Dearborn Street, then the route step representing the collector-distributor way should have a
destinations
ofDearborn Street;James Street;Madison Street
and aninstruction
mentioning Dearborn Street. On the other hand, if the route travels towards Spokane on eastbound I-90, then that same route step should have adestinations
ofI 90 East: Spokane
and aninstruction
that mentions Spokane.#2553 (comment) suggests that
destination:lanes
could help deduce the correct lane to take./ref mapbox/mapping#308 Project-OSRM/osrm-text-instructions#30
/cc @freenerd @daniel-j-h
The text was updated successfully, but these errors were encountered: