-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
180 create intergration tests for overall simulator #215
base: main
Are you sure you want to change the base?
180 create intergration tests for overall simulator #215
Conversation
… with the input demands from the esdl. Attest part still missing.
…mulator Main update.
…mulator Updating main branch.
This is the first version of the integration tests. It runs the sample esdl as a test simulation. For now it runs two tests. The first one calculates the consumption at the demand asset using the mass flow, cp and delta T and compares it with the demand profile from the esdl. The second test checks whether the return temperature is lower than the primary one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general good basis, but we need to discuss what do we want to test here, what is the purpose of this test. Do we want to compare with results from previous release or just test if it runs.
ci/win32/create_venv.cmd
Outdated
@@ -3,6 +3,7 @@ rem @echo off | |||
|
|||
pushd . | |||
cd /D "%~dp0" | |||
py -3.11 -m pip install virtualenv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add this, this doe snot seem to have anything to do with the PR and is it required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I just added it to install the repo in my machine and then forgot to remove it afterwards. I will remove it in the next commit.
@@ -43,7 +43,7 @@ def run(file_path: str | None = None) -> pd.DataFrame: | |||
name="test run", | |||
timestep=3600, | |||
start=datetime.strptime("2019-01-01T00:00:00", "%Y-%m-%dT%H:%M:%S"), | |||
stop=datetime.strptime("2019-01-01T01:00:00", "%Y-%m-%dT%H:%M:%S"), | |||
stop=datetime.strptime("2019-01-01T09:00:00", "%Y-%m-%dT%H:%M:%S"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not required right, so then remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I just changed while testing something and forgot to remove it. It's removed in the latest commit.
|
||
return temp_in_dict, temp_out_dict | ||
|
||
def test_heat_power(self) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not get why you want to test this, since it might be that the production is to low so the consumption is capped, and this test will fail.
No description provided.