Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

193 set priority based on marginal costs #198

Merged
merged 13 commits into from
Nov 7, 2024
Merged

193 set priority based on marginal costs #198

merged 13 commits into from
Nov 7, 2024

Conversation

samvanderzwan
Copy link
Contributor

Added support for running with priority based on marginal costs.
Added also a test model, but did not yet included a test to run it.
Also needed some fixing in the solver since the sign for the set mass flow rate was not corrected.
Also found out that port order in esdl is not fixed so we need to fix this before V0.5

@samvanderzwan samvanderzwan linked an issue Oct 31, 2024 that may be closed by this pull request
Set priority based on marginal costs #193
Closed
vanmeerkerk
vanmeerkerk requested changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@vanmeerkerk vanmeerkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets have a call to discuss comments

src/omotes_simulator_core/adapter/transforms/esdl_asset_mapper.py Show resolved Hide resolved
src/omotes_simulator_core/entities/assets/controller/controller_producer.py Show resolved Hide resolved
src/omotes_simulator_core/entities/assets/esdl_asset_object.py Outdated Show resolved Hide resolved
src/omotes_simulator_core/entities/network_controller.py Outdated Show resolved Hide resolved
src/omotes_simulator_core/entities/network_controller.py Show resolved Hide resolved
src/omotes_simulator_core/solver/network/assets/production_asset.py Outdated Show resolved Hide resolved
testdata/test1.esdl Show resolved Hide resolved
unit_test/entities/test_esdl_object.py Show resolved Hide resolved
unit_test/entities/controller/test_controller_class.py Show resolved Hide resolved
unit_test/entities/controller/test_controller_class.py Show resolved Hide resolved
@samvanderzwan
Copy link
Contributor Author

I replied and fixed the comments. Back to you @vanmeerkerk

vanmeerkerk
vanmeerkerk reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@vanmeerkerk vanmeerkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final points and there is still one discussion point that we need to address

src/omotes_simulator_core/entities/assets/controller/controller_producer.py Show resolved Hide resolved
vanmeerkerk
vanmeerkerk previously approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@vanmeerkerk vanmeerkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Therer is still one point to discuss but that could also be a fix outside of this PR.

src/omotes_simulator_core/entities/assets/controller/controller_producer.py Show resolved Hide resolved
src/omotes_simulator_core/adapter/transforms/esdl_asset_mapper.py Show resolved Hide resolved
@vanmeerkerk vanmeerkerk merged commit 02d096c into main Nov 7, 2024
6 checks passed
@vanmeerkerk vanmeerkerk deleted the 193-set-priority-based-on-marginal-costs branch November 7, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanmeerkerk vanmeerkerk vanmeerkerk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set priority based on marginal costs
2 participants
@samvanderzwan @vanmeerkerk