Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed supply temperature not set correctly. #190

Conversation

samvanderzwan
Copy link
Contributor

No description provided.

Copy link
Contributor

@vanmeerkerk vanmeerkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See single comment on testing. I doubt whether the test is now complete enough to cover the problem of not setting the correct definitions.

unit_test/entities/test_esdl_object.py Show resolved Hide resolved
Copy link
Contributor

@vanmeerkerk vanmeerkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed.

@vanmeerkerk vanmeerkerk merged commit 45fc15d into main Oct 24, 2024
6 checks passed
@vanmeerkerk vanmeerkerk deleted the 189-bug-return-temeprature-of-demand-cluster-is-not-set-correctly branch October 24, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: return temeprature of demand cluster is not set correctly
2 participants