Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

156 refactor 2 connection point limitation to 4 connection points #160

Merged
merged 15 commits into from
Sep 16, 2024
Merged

156 refactor 2 connection point limitation to 4 connection points #160

merged 15 commits into from
Sep 16, 2024

Conversation

samvanderzwan
Copy link
Contributor

Code has been refactored.
Asset do not know anymore if the port is in or out port. If we need this info we need to add it.
The order is just the order as they are in the esdl file

@samvanderzwan samvanderzwan linked an issue Sep 3, 2024 that may be closed by this pull request
Refactor 2 connection point limitation to 4 connection points #156
Closed
vanmeerkerk
vanmeerkerk requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@vanmeerkerk vanmeerkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik heb nog een aantal comments geplaatst.

src/omotes_simulator_core/entities/assets/heat_pump.py Show resolved Hide resolved
src/omotes_simulator_core/adapter/transforms/mappers.py Outdated Show resolved Hide resolved
src/omotes_simulator_core/adapter/transforms/mappers.py Show resolved Hide resolved
src/omotes_simulator_core/adapter/transforms/mappers.py Outdated Show resolved Hide resolved
src/omotes_simulator_core/entities/assets/asset_abstract.py Show resolved Hide resolved
unit_test/transforms/test_mapper.py Show resolved Hide resolved
unit_test/transforms/test_mapper.py Outdated Show resolved Hide resolved
src/omotes_simulator_core/adapter/transforms/mappers.py Show resolved Hide resolved
unit_test/entities/test_esdl_object.py Outdated Show resolved Hide resolved
src/omotes_simulator_core/adapter/transforms/mappers.py Show resolved Hide resolved
vanmeerkerk
vanmeerkerk requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@vanmeerkerk vanmeerkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik heb nog een aantal comments geplaatst.

vanmeerkerk
vanmeerkerk reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@vanmeerkerk vanmeerkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik heb nog een paar kleine opmerkingen.

src/omotes_simulator_core/adapter/transforms/mappers.py Show resolved Hide resolved
src/omotes_simulator_core/adapter/transforms/mappers.py Outdated Show resolved Hide resolved
src/omotes_simulator_core/entities/assets/asset_abstract.py Show resolved Hide resolved
vanmeerkerk
vanmeerkerk approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@vanmeerkerk vanmeerkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prima

@vanmeerkerk vanmeerkerk merged commit 478f61d into main Sep 16, 2024
6 checks passed
@vanmeerkerk vanmeerkerk deleted the 156-refactor-2-connection-point-limitation-to-4-connection-points branch September 16, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanmeerkerk vanmeerkerk vanmeerkerk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor 2 connection point limitation to 4 connection points
2 participants
@samvanderzwan @vanmeerkerk