-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
35: Move orchestrator db schema here and rewire integration test to u… #36
Conversation
…se computation engine as a submodule.
…strator/ to make the docker compose project more descriptive and add a first version of README. Also make some alembic scripts available to work with database revisions.
…opped for test worker.
…ake a relevant example and committing it here. Adds unit tests for the new_job_submitted_handler in main.py:Orchestrator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again really nice to have these tests available, extremely useful!
A couple of general remarks:
- There are a lot of console prints during the integration test, this would probably make it harder to track down issues. Is it possible to reduce the prints?
- Should we divide
unit_test/test_main.py
into several files? - I really appreciate your effort in creating 'win32' cmd files, however I don't use them.. Since two weeks I run everything under WSL (file system and venv) and before I was using 'git bash' for the shell scripts. So as far as I am concerned we can leave out these cmd files. It is much better to develop with the same scripts as will be used on ci.
…containers as well.
…n.sh instead of older run.sh and setup.sh
…stead of crashing whole program.
Quieted down by setting the log level.
I would vote not yet. This PR is quite big already. Also, a large test file is usually a sign the 'file under test' (
Michiel requires them. |
Also, there remains an issue that sometimes causes the integration test to fail. It is an issue within aio-pika. I have captured the issue here mosquito/aio-pika#630 and will solve it myself. Unsure when it gets solved and merged in. Should not be an issue on production systems as the main reason it fails in the integration test is because the jobs finish so extremely fast. Jobs within omotes takes at least a couple of seconds at the moment. Should be fixed ASAP (high priority). Reminder captured here: #37 |
Thanks for resolving! If not, should we provide cmd equivalents for all scripts? For instance the |
I am not sure exactly what his current working process is but I know he can work with cmd and ps files. |
…se computation engine as a submodule.
Needs to be coordinated with Project-OMOTES/omotes-system#43