54 figure out a better alternative for the celery subprocess in subprocess problem #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d upon a cancel and encapsulate SystemExit exceptions which are thrown by Mesido into an EarlySystemExit.
lfse-slafleur
commented
Jun 17, 2024
| update_progress_function=None, | ||
| profile_reader=InfluxDBProfileReader, | ||
| ) | ||
| except SystemExit as e: |
There was a problem hiding this comment.
This is only triggered when mesido throws the SystemExit as it runs in a subprocess
lfse-slafleur
commented
Jun 17, 2024
| output_esdl = pool.map(run_mesido, [input_esdl])[0] | ||
| try: | ||
| output_esdl = pool.map(run_mesido, [input_esdl])[0] | ||
| except SystemExit as e: |
There was a problem hiding this comment.
This is triggered when Celery throws a SystemExit to cancel the current task. It will terminate the mesido worker subprocess with a SIGKILL to ensure it does not wait till it dies gracefully. Casadi is blocking any way to gracefully shutdown the process as it doesn't release the GIL.
lfse-slafleur
commented
Jun 17, 2024
| @@ -23,6 +26,16 @@ | |||
| GROW_TASK_TYPE = GrowTaskType(os.environ.get("GROW_TASK_TYPE")) | |||
|
|
|||
|
|
|||
| class EarlySystemExit(Exception): | |||
There was a problem hiding this comment.
Moved from omotes-sdk-python to here. As Celery uses the SystemExit mechanism to also stop the running worker gracefully, before it would catch the SystemExit and not let the worker process terminate as expected.
MarkTNO
approved these changes
Jun 17, 2024
lfse-slafleur
deleted the
54-figure-out-a-better-alternative-for-the-celery-subprocess-in-subprocess-problem
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.