verify properties for model-zoo bundle #601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return apps_url_data | ||
|
|
||
|
|
||
| def verify(models_path="models", bundle="", download_path="download"): |
There was a problem hiding this comment.
please use existing functions and extend your new feature
mingxueg-nv
force-pushed
the
config_properties
branch
2 times, most recently
from
e4a95a7 to
371b779
Compare
for more information, see https://pre-commit.ci
…del-zoo into config_properties
| # update apps bundle properties to workflow properties | ||
| from properties import InferProperties, MetaProperties | ||
|
|
||
| workflow.properties = {**MetaProperties, **InferProperties} |
There was a problem hiding this comment.
it's not the formal way. You need to set properties_path for BundleWorkflow
monai-bot
force-pushed
the
config_properties
branch
from
73130e5 to
99ac58f
Compare
|
This PR can close since the new one is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
Add verifying properties ci for model-zoo bundle
Status
Work in progress
Please ensure all the checkboxes:
./runtests.sh --codeformat.versionandchangeloginmetadata.jsonif changing an existing bundle.CONTRIBUTING.md).monai,pytorchandnumpyare correct inmetadata.json.eval_metricsof the provided weights and TorchScript modules.large_file.yml./home/your_name/for"bundle_root").