Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify properties for model-zoo bundle #601

Closed
wants to merge 4 commits into from

Conversation

mingxueg-nv
Copy link
Contributor

@mingxueg-nv mingxueg-nv commented Jul 22, 2024

Fixes # .

Description

Add verifying properties ci for model-zoo bundle

Status

Work in progress

Please ensure all the checkboxes:

  • Codeformat tests passed locally by running ./runtests.sh --codeformat.
  • In-line docstrings updated.
  • Update version and changelog in metadata.json if changing an existing bundle.
  • Please ensure the naming rules in config files meet our requirements (please refer to: CONTRIBUTING.md).
  • Ensure versions of packages such as monai, pytorch and numpy are correct in metadata.json.
  • Descriptions should be consistent with the content, such as eval_metrics of the provided weights and TorchScript modules.
  • Files larger than 25MB are excluded and replaced by providing download links in large_file.yml.
  • Avoid using path that contains personal information within config files (such as use /home/your_name/ for "bundle_root").

return apps_url_data


def verify(models_path="models", bundle="", download_path="download"):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use existing functions and extend your new feature

@mingxueg-nv mingxueg-nv force-pushed the config_properties branch 2 times, most recently from e4a95a7 to 371b779 Compare July 22, 2024 07:00
# update apps bundle properties to workflow properties
from properties import InferProperties, MetaProperties

workflow.properties = {**MetaProperties, **InferProperties}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not the formal way. You need to set properties_path for BundleWorkflow

@yiheng-wang-nv
Copy link
Collaborator

This PR can close since the new one is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants