6676 port generative networks vqvae #7285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes model-zoo#537 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: Mark Graham <[email protected]>
Signed-off-by: Mark Graham <[email protected]>
Signed-off-by: Mark Graham <[email protected]>
Signed-off-by: Mark Graham <[email protected]>
KumoLiu
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Thanks for the pr. Several minor comments inline.
Please also fix DCO error.
And seems there also has a version issue, please also fix it. Thanks!
https://github.com/Project-MONAI/MONAI/actions/runs/7088708828/job/19291787433?pr=7285#step:8:12578
Signed-off-by: Mark Graham <[email protected]>
I, Mark Graham <[email protected]>, hereby add my Signed-off-by to this commit: 8cf0525 Signed-off-by: Mark Graham <[email protected]>
Signed-off-by: Mark Graham <[email protected]>
Co-authored-by: YunLiu <[email protected]> Signed-off-by: Mark Graham <[email protected]>
Signed-off-by: Mark Graham <[email protected]>
…ksgraham/MONAI into 6676_port_generative_networks_vqvae]
Signed-off-by: Mark Graham <[email protected]>
…r networks Signed-off-by: Mark Graham <[email protected]>
Signed-off-by: Mark Graham <[email protected]>
Signed-off-by: Mark Graham <[email protected]>
|
Thanks @KumoLiu , I've addressed your comments. It seems you need to address one of the DCO errors, I guess from the initial commit which got included from dev. Are you able to fix that? I'll look into properly syncing gen-ai and dev so that doesn't happen in future commits |
…hub.com> I, YunLiu <[email protected]>, hereby add my Signed-off-by to this commit: 2fc0126 Signed-off-by: YunLiu <[email protected]>
I, KumoLiu <[email protected]>, hereby add my Signed-off-by to this commit: 398e41f Signed-off-by: KumoLiu <[email protected]>
for more information, see https://pre-commit.ci
…hub.com> I, YunLiu <[email protected]>, hereby add my Signed-off-by to this commit: 2fc0126 Signed-off-by: YunLiu <[email protected]>
for more information, see https://pre-commit.ci
I, KumoLiu <[email protected]>, hereby add my Signed-off-by to this commit: 10ae421 Signed-off-by: KumoLiu <[email protected]> DCO Remediation Commit for YunLiu <[email protected]> I, YunLiu <[email protected]>, hereby add my Signed-off-by to this commit: 2fc0126 Signed-off-by: YunLiu <[email protected]>
….com/marksgraham/MONAI into 6676_port_generative_networks_vqvae]
…hub.com> I, YunLiu <[email protected]>, hereby add my Signed-off-by to this commit: 2fc0126 Signed-off-by: YunLiu <[email protected]>
for more information, see https://pre-commit.ci
I, KumoLiu <[email protected]>, hereby add my Signed-off-by to this commit: e830b1f Signed-off-by: KumoLiu <[email protected]> DCO Remediation Commit for YunLiu <[email protected]> I, YunLiu <[email protected]>, hereby add my Signed-off-by to this commit: 2fc0126 Signed-off-by: YunLiu <[email protected]> Signed-off-by: KumoLiu <[email protected]>
…hub.com> I, YunLiu <[email protected]>, hereby add my Signed-off-by to this commit: 2fc0126 Signed-off-by: YunLiu <[email protected]> Signed-off-by: KumoLiu <[email protected]>
…hub.com> I, YunLiu <[email protected]>, hereby add my Signed-off-by to this commit: 2fc0126 Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Nic-Ma
reviewed
Dec 6, 2023
Nic-Ma
approved these changes
Dec 6, 2023
Signed-off-by: YunLiu <[email protected]>
|
/build |
marksgraham
added a commit
to marksgraham/MONAI
that referenced
this pull request
Jan 30, 2024
Partially fixes Project-MONAI#6676 ### Description Implements the VQ-VAE network, including the vector quantizer block, from MONAI Generative. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: KumoLiu <[email protected]> Signed-off-by: Mark Graham <[email protected]> Signed-off-by: YunLiu <[email protected]> Co-authored-by: YunLiu <[email protected]> Co-authored-by: KumoLiu <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Mark Graham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #6676
Description
Implements the VQ-VAE network, including the vector quantizer block, from MONAI Generative.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.