not to remove the merged file path from the saved data #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abdalsalaam
requested changes
Nov 28, 2024
Comment on lines
+707
to
+708
| $label_format = $this->settings->get_label_format(); | ||
| $filename = Utils::generate_label_name( $order->get_id(), $label_type, $barcode, $label_format, $label_extension ); |
There was a problem hiding this comment.
but the label file returned from API is always A6, is there a reason for this?
There was a problem hiding this comment.
@Abdalsalaam It cause a fatal error when it generate files with format A4 then try to create the label again from bulk action because file path is A6 but the one saved to database is A4
Co-authored-by: Abdalsalaam Halawa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contain fix for this issue