Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Drop point and delivery day blocks #191

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Conversation

sal4sup
Copy link
Collaborator

@sal4sup sal4sup commented Oct 21, 2024

  • Created Drop Point Block
  • Created Delivery Day Block
  • Added shipping and billing address fields
  • Handled data returned from the API
  • Stored order values on the backend

@sal4sup sal4sup requested a review from Abdalsalaam October 21, 2024 15:17
@sal4sup sal4sup requested a review from iyut November 5, 2024 09:23
@iyut
Copy link
Collaborator

iyut commented Nov 11, 2024

I got this fatal error when I tried to activate the plugin :
Screenshot 2024-11-11 at 09 25 58

I have runned : composer i nvm i npm i npm run build

Do you guys doesnt get this?

@sal4sup
Copy link
Collaborator Author

sal4sup commented Nov 12, 2024

I got this fatal error when I tried to activate the plugin : Screenshot 2024-11-11 at 09 25 58

I have runned : composer i nvm i npm i npm run build

Do you guys doesnt get this?

@iyut
Sorry there was a problem because block methods were called before constants were defined
092d88b

Copy link
Collaborator

@iyut iyut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can clean the unneeded files on this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to start utilize the feature from SCSS since we're using scss file.

Copy link
Collaborator

@iyut iyut Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this file? CMIIW, but I think block.json only needed for the main js file such as index.js or frontend.js.

Copy link
Collaborator

@iyut iyut Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this file? CMIIW, but I think block.json only needed for the main js file such as index.js or frontend.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants